From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54958) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XcVrD-0005oK-1P for qemu-devel@nongnu.org; Fri, 10 Oct 2014 04:47:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XcVr3-0005Y8-C9 for qemu-devel@nongnu.org; Fri, 10 Oct 2014 04:47:26 -0400 Received: from e06smtp15.uk.ibm.com ([195.75.94.111]:56290) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XcVr3-0005XQ-27 for qemu-devel@nongnu.org; Fri, 10 Oct 2014 04:47:17 -0400 Received: from /spool/local by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 10 Oct 2014 09:47:15 +0100 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id C3E2117D8059 for ; Fri, 10 Oct 2014 09:49:25 +0100 (BST) Received: from d06av06.portsmouth.uk.ibm.com (d06av06.portsmouth.uk.ibm.com [9.149.37.217]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id s9A8lBXV61210724 for ; Fri, 10 Oct 2014 08:47:11 GMT Received: from d06av06.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av06.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s9A3j6t7032336 for ; Thu, 9 Oct 2014 23:45:06 -0400 Date: Fri, 10 Oct 2014 10:47:09 +0200 From: Cornelia Huck Message-ID: <20141010104709.4a84cb4d.cornelia.huck@de.ibm.com> In-Reply-To: <1412849855-12661-16-git-send-email-pbonzini@redhat.com> References: <1412849438-12274-1-git-send-email-pbonzini@redhat.com> <1412849855-12661-16-git-send-email-pbonzini@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL 23/28] kvm: Make KVMState be the TYPE_KVM_ACCEL instance struct List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, Eduardo Habkost On Thu, 9 Oct 2014 12:17:30 +0200 Paolo Bonzini wrote: > From: Eduardo Habkost >=20 > Now that we create an accel object before calling machine_init, we can > simply use the accel object to save all KVMState data, instead of > allocationg KVMState manually. >=20 > Reviewed-by: Paolo Bonzini > Signed-off-by: Eduardo Habkost > Signed-off-by: Paolo Bonzini > --- > kvm-all.c | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) This patch breaks compilation on s390 for me: CC s390x-softmmu/kvm-all.o /home/cohuck/git/qemu/kvm-all.c:110: error: redefinition of typedef =E2=80= =98KVMState=E2=80=99 /home/cohuck/git/qemu/include/sysemu/kvm.h:161: error: previous declaration= of =E2=80=98KVMState=E2=80=99 was here