From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59192)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cornelia.huck@de.ibm.com>) id 1XcWF3-0005ew-6T
	for qemu-devel@nongnu.org; Fri, 10 Oct 2014 05:12:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <cornelia.huck@de.ibm.com>) id 1XcWEu-0005jg-5c
	for qemu-devel@nongnu.org; Fri, 10 Oct 2014 05:12:05 -0400
Received: from e06smtp16.uk.ibm.com ([195.75.94.112]:57879)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cornelia.huck@de.ibm.com>) id 1XcWEt-0005iB-Rm
	for qemu-devel@nongnu.org; Fri, 10 Oct 2014 05:11:56 -0400
Received: from /spool/local
	by e06smtp16.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <cornelia.huck@de.ibm.com>;
	Fri, 10 Oct 2014 10:11:54 +0100
Received: from b06cxnps4076.portsmouth.uk.ibm.com
	(d06relay13.portsmouth.uk.ibm.com [9.149.109.198])
	by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 5371E17D8043
	for <qemu-devel@nongnu.org>; Fri, 10 Oct 2014 10:14:07 +0100 (BST)
Received: from d06av12.portsmouth.uk.ibm.com (d06av12.portsmouth.uk.ibm.com
	[9.149.37.247])
	by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with
	ESMTP id s9A9BrFm58196018
	for <qemu-devel@nongnu.org>; Fri, 10 Oct 2014 09:11:53 GMT
Received: from d06av12.portsmouth.uk.ibm.com (localhost [127.0.0.1])
	by d06av12.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with
	ESMTP id s9A9Bqkt009365
	for <qemu-devel@nongnu.org>; Fri, 10 Oct 2014 03:11:52 -0600
Date: Fri, 10 Oct 2014 11:11:50 +0200
From: Cornelia Huck <cornelia.huck@de.ibm.com>
Message-ID: <20141010111150.13d14f0d.cornelia.huck@de.ibm.com>
In-Reply-To: <20141010104709.4a84cb4d.cornelia.huck@de.ibm.com>
References: <1412849438-12274-1-git-send-email-pbonzini@redhat.com>
	<1412849855-12661-16-git-send-email-pbonzini@redhat.com>
	<20141010104709.4a84cb4d.cornelia.huck@de.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PULL 23/28] kvm: Make KVMState be the
 TYPE_KVM_ACCEL instance struct
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>

On Fri, 10 Oct 2014 10:47:09 +0200
Cornelia Huck <cornelia.huck@de.ibm.com> wrote:

> On Thu,  9 Oct 2014 12:17:30 +0200
> Paolo Bonzini <pbonzini@redhat.com> wrote:
>=20
> > From: Eduardo Habkost <ehabkost@redhat.com>
> >=20
> > Now that we create an accel object before calling machine_init, we can
> > simply use the accel object to save all KVMState data, instead of
> > allocationg KVMState manually.
> >=20
> > Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
> > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> > ---
> >  kvm-all.c | 13 +++++++++----
> >  1 file changed, 9 insertions(+), 4 deletions(-)
>=20
> This patch breaks compilation on s390 for me:
>=20
>   CC    s390x-softmmu/kvm-all.o
> /home/cohuck/git/qemu/kvm-all.c:110: error: redefinition of typedef =E2=
=80=98KVMState=E2=80=99
> /home/cohuck/git/qemu/include/sysemu/kvm.h:161: error: previous declarati=
on of =E2=80=98KVMState=E2=80=99 was here

Seems to be compiler version dependant. With the SLES11SP3 compiler
(calls itself 4.3.4), I get the failure above. With newer compilers
(4.6+), it builds fine.