From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36122)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1XcYzO-00034i-2n
	for qemu-devel@nongnu.org; Fri, 10 Oct 2014 08:08:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1XcYzH-0002N5-VM
	for qemu-devel@nongnu.org; Fri, 10 Oct 2014 08:08:06 -0400
Received: from mx1.redhat.com ([209.132.183.28]:52875)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1XcYzH-0002Ll-OZ
	for qemu-devel@nongnu.org; Fri, 10 Oct 2014 08:07:59 -0400
Date: Fri, 10 Oct 2014 17:37:51 +0530
From: Amit Shah <amit.shah@redhat.com>
Message-ID: <20141010120751.GG16326@grmbl.mre>
References: <e5940c2ffd01e4bcf23354fdcf37f9befb440a05.1412093582.git.amit.shah@redhat.com>
	<87fvexfq4n.fsf@blackfin.pond.sub.org>
	<20141009121714.GA22195@grmbl.mre>
	<CAFEAcA-NeWpgst9qEkZzsBs1MBQRaP5R_Zg8E=AcW9f5aAOWwA@mail.gmail.com>
	<20141010111918.GE16326@grmbl.mre>
	<CAFEAcA_f_y4bOn83tkpm4ekb87exFHq4P341Vb4u9QAXr6A3hg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFEAcA_f_y4bOn83tkpm4ekb87exFHq4P341Vb4u9QAXr6A3hg@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH v2 1/1] virtio: serial: expose a
 'guest_writable' callback for users
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: marcandre.lureau@redhat.com, Amos Kong <akong@redhat.com>, Markus Armbruster <armbru@redhat.com>, qemu list <qemu-devel@nongnu.org>

On (Fri) 10 Oct 2014 [12:23:21], Peter Maydell wrote:
> On 10 October 2014 12:19, Amit Shah <amit.shah@redhat.com> wrote:
> > On (Thu) 09 Oct 2014 [14:04:53], Peter Maydell wrote:
> >> What I would like to see in this patch is a comment giving
> >> much clearer definition of the semantics of the guest_writable
> >> call: for instance, is it always called when the guest is
> >> writable, or is it only guaranteed to be called if the
> >> QEMU backend has previously tried to do virtio_serial_write
> >> and got back a return code indicating an incomplete write?
> >
> > Right now it's called always; if it's necessary to only call after an
> > incomplete / failed write, we just need to implement that (and also
> > add that state to the migration data).
> >
> > I have no preference; just depends on the users of the API.
> 
> Called-always makes sense; I'd just like to see the semantics
> documented so you don't have to read the whole implementation
> of virtio to figure out what they are :-)

Sure.  I'll do that.


		Amit