From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42049)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@nodalink.com>) id 1Xd1pr-0001Kt-Vl
	for qemu-devel@nongnu.org; Sat, 11 Oct 2014 14:56:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benoit.canet@nodalink.com>) id 1Xd1pk-0001X3-0A
	for qemu-devel@nongnu.org; Sat, 11 Oct 2014 14:56:11 -0400
Received: from dew.nodalink.com ([95.130.14.197]:40594)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@nodalink.com>) id 1Xd1pj-0001Wo-Q5
	for qemu-devel@nongnu.org; Sat, 11 Oct 2014 14:56:03 -0400
Date: Sat, 11 Oct 2014 18:56:25 +0000
From: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@nodalink.com>
Message-ID: <20141011185625.GA25059@nodalink.com>
References: <1409348463-16627-1-git-send-email-mreitz@redhat.com>
	<1409348463-16627-9-git-send-email-mreitz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <1409348463-16627-9-git-send-email-mreitz@redhat.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v5 08/11] qcow2: Rebuild refcount structure
	during check
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Reitz <mreitz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org, =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@nodalink.com>


> +    int64_t first_free_cluster =3D 0, rt_ofs =3D -1, cluster =3D 0;
> +    int64_t rb_ofs, rb_start, rb_index;

Everytime a few day pass and I read rb_ofs and rt_ofs again I found these=
 names
obfuscated. I know Linus says that C is a spartan language but these look=
 odd.
Maybe refcount_block_offset, refcount_block_* and refcount_table_offset w=
ould be
better.

I'll try to read this patch for real before you repost it.

Best regards

Beno=EEt