* [Qemu-devel] [PATCH] hw/display/vga: Remove unused arrays dmask4 and dmask16
@ 2014-10-10 19:44 Peter Maydell
2014-10-10 20:26 ` Benjamin Herrenschmidt
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Peter Maydell @ 2014-10-10 19:44 UTC (permalink / raw)
To: qemu-devel; +Cc: David Gibson, Gerd Hoffmann, patches
Following cleanup of the vga device code in commit d2e043a8041,
the arrays dmask4 and dmask16 are now unused. gcc doesn't warn
about this, but clang does; remove them.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
hw/display/vga.c | 26 --------------------------
1 file changed, 26 deletions(-)
diff --git a/hw/display/vga.c b/hw/display/vga.c
index 19e7f23..52eaf05 100644
--- a/hw/display/vga.c
+++ b/hw/display/vga.c
@@ -136,32 +136,6 @@ static const uint32_t mask16[16] = {
#define PAT(x) cbswap_32(x)
#endif
-static const uint32_t dmask16[16] = {
- PAT(0x00000000),
- PAT(0x000000ff),
- PAT(0x0000ff00),
- PAT(0x0000ffff),
- PAT(0x00ff0000),
- PAT(0x00ff00ff),
- PAT(0x00ffff00),
- PAT(0x00ffffff),
- PAT(0xff000000),
- PAT(0xff0000ff),
- PAT(0xff00ff00),
- PAT(0xff00ffff),
- PAT(0xffff0000),
- PAT(0xffff00ff),
- PAT(0xffffff00),
- PAT(0xffffffff),
-};
-
-static const uint32_t dmask4[4] = {
- PAT(0x00000000),
- PAT(0x0000ffff),
- PAT(0xffff0000),
- PAT(0xffffffff),
-};
-
static uint32_t expand4[256];
static uint16_t expand2[256];
static uint8_t expand4to8[16];
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] hw/display/vga: Remove unused arrays dmask4 and dmask16
2014-10-10 19:44 [Qemu-devel] [PATCH] hw/display/vga: Remove unused arrays dmask4 and dmask16 Peter Maydell
@ 2014-10-10 20:26 ` Benjamin Herrenschmidt
2014-10-12 5:37 ` David Gibson
2014-10-14 6:55 ` Gerd Hoffmann
2 siblings, 0 replies; 4+ messages in thread
From: Benjamin Herrenschmidt @ 2014-10-10 20:26 UTC (permalink / raw)
To: Peter Maydell; +Cc: David Gibson, Gerd Hoffmann, qemu-devel, patches
On Fri, 2014-10-10 at 20:44 +0100, Peter Maydell wrote:
> Following cleanup of the vga device code in commit d2e043a8041,
> the arrays dmask4 and dmask16 are now unused. gcc doesn't warn
> about this, but clang does; remove them.
Ah right, I missed those, thanks.
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> hw/display/vga.c | 26 --------------------------
> 1 file changed, 26 deletions(-)
>
> diff --git a/hw/display/vga.c b/hw/display/vga.c
> index 19e7f23..52eaf05 100644
> --- a/hw/display/vga.c
> +++ b/hw/display/vga.c
> @@ -136,32 +136,6 @@ static const uint32_t mask16[16] = {
> #define PAT(x) cbswap_32(x)
> #endif
>
> -static const uint32_t dmask16[16] = {
> - PAT(0x00000000),
> - PAT(0x000000ff),
> - PAT(0x0000ff00),
> - PAT(0x0000ffff),
> - PAT(0x00ff0000),
> - PAT(0x00ff00ff),
> - PAT(0x00ffff00),
> - PAT(0x00ffffff),
> - PAT(0xff000000),
> - PAT(0xff0000ff),
> - PAT(0xff00ff00),
> - PAT(0xff00ffff),
> - PAT(0xffff0000),
> - PAT(0xffff00ff),
> - PAT(0xffffff00),
> - PAT(0xffffffff),
> -};
> -
> -static const uint32_t dmask4[4] = {
> - PAT(0x00000000),
> - PAT(0x0000ffff),
> - PAT(0xffff0000),
> - PAT(0xffffffff),
> -};
> -
> static uint32_t expand4[256];
> static uint16_t expand2[256];
> static uint8_t expand4to8[16];
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] hw/display/vga: Remove unused arrays dmask4 and dmask16
2014-10-10 19:44 [Qemu-devel] [PATCH] hw/display/vga: Remove unused arrays dmask4 and dmask16 Peter Maydell
2014-10-10 20:26 ` Benjamin Herrenschmidt
@ 2014-10-12 5:37 ` David Gibson
2014-10-14 6:55 ` Gerd Hoffmann
2 siblings, 0 replies; 4+ messages in thread
From: David Gibson @ 2014-10-12 5:37 UTC (permalink / raw)
To: Peter Maydell; +Cc: Gerd Hoffmann, qemu-devel, patches
[-- Attachment #1: Type: text/plain, Size: 559 bytes --]
On Fri, Oct 10, 2014 at 08:44:29PM +0100, Peter Maydell wrote:
> Following cleanup of the vga device code in commit d2e043a8041,
> the arrays dmask4 and dmask16 are now unused. gcc doesn't warn
> about this, but clang does; remove them.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/display/vga: Remove unused arrays dmask4 and dmask16
2014-10-10 19:44 [Qemu-devel] [PATCH] hw/display/vga: Remove unused arrays dmask4 and dmask16 Peter Maydell
2014-10-10 20:26 ` Benjamin Herrenschmidt
2014-10-12 5:37 ` David Gibson
@ 2014-10-14 6:55 ` Gerd Hoffmann
2 siblings, 0 replies; 4+ messages in thread
From: Gerd Hoffmann @ 2014-10-14 6:55 UTC (permalink / raw)
To: Peter Maydell; +Cc: David Gibson, qemu-devel, patches
On Fr, 2014-10-10 at 20:44 +0100, Peter Maydell wrote:
> Following cleanup of the vga device code in commit d2e043a8041,
> the arrays dmask4 and dmask16 are now unused. gcc doesn't warn
> about this, but clang does; remove them.
Queued up.
thanks,
Gerd
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-10-14 6:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-10 19:44 [Qemu-devel] [PATCH] hw/display/vga: Remove unused arrays dmask4 and dmask16 Peter Maydell
2014-10-10 20:26 ` Benjamin Herrenschmidt
2014-10-12 5:37 ` David Gibson
2014-10-14 6:55 ` Gerd Hoffmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).