qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: thuth@linux.vnet.ibm.com, qemu-devel@nongnu.org,
	kvm@vger.kernel.org, virtualization@lists.linux-foundation.org
Subject: Re: [Qemu-devel] [PATCH RFC 08/11] virtio_blk: use virtio v1.0 endian
Date: Mon, 13 Oct 2014 12:42:52 +0200	[thread overview]
Message-ID: <20141013124252.7e9c6549.cornelia.huck@de.ibm.com> (raw)
In-Reply-To: <878ukkecjb.fsf@rustcorp.com.au>

On Mon, 13 Oct 2014 16:28:32 +1030
Rusty Russell <rusty@rustcorp.com.au> wrote:

> Cornelia Huck <cornelia.huck@de.ibm.com> writes:
> > Note that we care only about the fields still in use for virtio v1.0.
> >
> > Reviewed-by: Thomas Huth <thuth@linux.vnet.ibm.com>
> > Reviewed-by: David Hildenbrand <dahi@linux.vnet.ibm.com>
> > Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> 
> Hi Cornelia,
> 
>         These patches all look good; 

Cool, thanks.

> I'm a bit nervous about our testing
> missing some conversion, so we'll need qemu patches for PCI so we can
> test on other platforms too.

The devices I looked at (blk and net) are probably OK as ccw needs to
convert always. I agree that we want to test on other platforms as
well, but unfortunately I not familiar enough with other platforms to
feel confident enough to convert virtio-pci and test it :(

  reply	other threads:[~2014-10-13 10:43 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-07 14:39 [Qemu-devel] [PATCH RFC 00/11] linux: towards virtio-1 guest support Cornelia Huck
2014-10-07 14:39 ` [Qemu-devel] [PATCH RFC 01/11] virtio: use u32, not bitmap for struct virtio_device's features Cornelia Huck
2014-10-07 14:39 ` [Qemu-devel] [PATCH RFC 02/11] virtio: add support for 64 bit features Cornelia Huck
2014-10-07 14:39 ` [Qemu-devel] [PATCH RFC 03/11] virtio: endianess conversion helpers Cornelia Huck
2014-10-22  9:04   ` Michael S. Tsirkin
2014-10-07 14:39 ` [Qemu-devel] [PATCH RFC 04/11] virtio_ring: implement endian reversal based on VERSION_1 feature Cornelia Huck
2014-10-22 14:02   ` Michael S. Tsirkin
2014-10-22 14:28     ` Cornelia Huck
2014-10-22 14:37       ` Michael S. Tsirkin
2014-10-07 14:39 ` [Qemu-devel] [PATCH RFC 05/11] virtio_config: endian conversion for v1.0 Cornelia Huck
2014-10-07 14:39 ` [Qemu-devel] [PATCH RFC 06/11] virtio: allow transports to get avail/used addresses Cornelia Huck
2014-10-07 14:39 ` [Qemu-devel] [PATCH RFC 07/11] virtio_net: use v1.0 endian Cornelia Huck
2014-10-07 14:39 ` [Qemu-devel] [PATCH RFC 08/11] virtio_blk: use virtio " Cornelia Huck
2014-10-13  5:58   ` Rusty Russell
2014-10-13 10:42     ` Cornelia Huck [this message]
2014-10-07 14:39 ` [Qemu-devel] [PATCH RFC 09/11] KVM: s390: Set virtio-ccw transport revision Cornelia Huck
2014-10-07 14:39 ` [Qemu-devel] [PATCH RFC 10/11] KVM: s390: virtio-ccw revision 1 SET_VQ Cornelia Huck
2014-10-07 14:39 ` [Qemu-devel] [PATCH RFC 11/11] KVM: s390: enable virtio-ccw revision 1 Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141013124252.7e9c6549.cornelia.huck@de.ibm.com \
    --to=cornelia.huck@de.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rusty@rustcorp.com.au \
    --cc=thuth@linux.vnet.ibm.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).