From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: thuth@linux.vnet.ibm.com, qemu-devel@nongnu.org,
kvm@vger.kernel.org, virtualization@lists.linux-foundation.org
Subject: Re: [Qemu-devel] [PATCH RFC 03/11] virtio: support more feature bits
Date: Mon, 13 Oct 2014 12:55:11 +0200 [thread overview]
Message-ID: <20141013125511.5d3475ab.cornelia.huck@de.ibm.com> (raw)
In-Reply-To: <87bnpgecqx.fsf@rustcorp.com.au>
On Mon, 13 Oct 2014 16:23:58 +1030
Rusty Russell <rusty@rustcorp.com.au> wrote:
> Cornelia Huck <cornelia.huck@de.ibm.com> writes:
> > With virtio-1, we support more than 32 feature bits. Let's make
> > vdev->guest_features depend on the number of supported feature bits,
> > allowing us to grow the feature bits automatically.
>
> It's a judgement call, but I would say that simply using uint64_t
> will be sufficient for quite a while.
I prefer this as an array for two reasons:
- It matches what ccw does anyway (we read/write features in chunks of
32 bit), so this makes the backend handling for this transport very
straightforward.
- While I don't see us running out of 64 feature bits for a while, we'd
have to touch every device and transport again when we do. I'd prefer
to do this once, as we need to change code anyway.
next prev parent reply other threads:[~2014-10-13 10:55 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-07 14:39 [Qemu-devel] [PATCH RFC 00/11] qemu: towards virtio-1 host support Cornelia Huck
2014-10-07 14:39 ` [Qemu-devel] [PATCH RFC 01/11] linux-headers/virtio_config: Update with VIRTIO_F_VERSION_1 Cornelia Huck
2014-10-07 14:39 ` [Qemu-devel] [PATCH RFC 02/11] virtio: cull virtio_bus_set_vdev_features Cornelia Huck
2014-10-07 14:39 ` [Qemu-devel] [PATCH RFC 03/11] virtio: support more feature bits Cornelia Huck
2014-10-13 5:53 ` Rusty Russell
2014-10-13 10:55 ` Cornelia Huck [this message]
2014-10-07 14:40 ` [Qemu-devel] [PATCH RFC 04/11] s390x/virtio-ccw: fix check for WRITE_FEAT Cornelia Huck
2014-10-07 14:40 ` [Qemu-devel] [PATCH RFC 05/11] virtio: introduce legacy virtio devices Cornelia Huck
2014-10-28 15:40 ` Greg Kurz
2014-10-30 18:02 ` Cornelia Huck
2014-10-30 22:29 ` Greg Kurz
2014-11-03 11:44 ` Cornelia Huck
2014-10-07 14:40 ` [Qemu-devel] [PATCH RFC 06/11] virtio: allow virtio-1 queue layout Cornelia Huck
2014-10-07 14:40 ` [Qemu-devel] [PATCH RFC 07/11] dataplane: allow virtio-1 devices Cornelia Huck
2014-10-28 15:22 ` Greg Kurz
2014-10-30 9:18 ` Cornelia Huck
2014-10-07 14:40 ` [Qemu-devel] [PATCH RFC 08/11] s390x/css: Add a callback for when subchannel gets disabled Cornelia Huck
2014-10-07 14:40 ` [Qemu-devel] [PATCH RFC 09/11] s390x/virtio-ccw: add virtio set-revision call Cornelia Huck
2014-10-07 14:40 ` [Qemu-devel] [PATCH RFC 10/11] s390x/virtio-ccw: support virtio-1 set_vq format Cornelia Huck
2014-10-07 14:40 ` [Qemu-devel] [PATCH RFC 11/11] s390x/virtio-ccw: enable virtio 1.0 Cornelia Huck
2014-10-08 1:24 ` [Qemu-devel] [PATCH RFC 00/11] qemu: towards virtio-1 host support Andy Lutomirski
2014-10-08 9:04 ` Cornelia Huck
2014-10-22 8:44 ` Michael S. Tsirkin
2014-10-22 14:17 ` Jan Kiszka
2014-10-22 14:36 ` Michael S. Tsirkin
2014-10-22 20:34 ` Benjamin Herrenschmidt
2014-10-23 6:44 ` Jan Kiszka
2014-10-23 9:18 ` Michael S. Tsirkin
2014-10-23 7:12 ` Michael S. Tsirkin
2014-10-23 21:42 ` Michael S. Tsirkin
2014-10-24 8:38 ` Cornelia Huck
2014-10-24 12:37 ` Cornelia Huck
2014-10-24 14:05 ` Michael S. Tsirkin
2014-10-24 14:17 ` Michael S. Tsirkin
2014-10-28 4:43 ` Michael S. Tsirkin
2014-10-30 16:52 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141013125511.5d3475ab.cornelia.huck@de.ibm.com \
--to=cornelia.huck@de.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=rusty@rustcorp.com.au \
--cc=thuth@linux.vnet.ibm.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).