From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33576) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XeNqm-0003ez-L6 for qemu-devel@nongnu.org; Wed, 15 Oct 2014 08:38:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XeNqg-0000OP-2Z for qemu-devel@nongnu.org; Wed, 15 Oct 2014 08:38:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56157) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XeNqf-0000OE-Qq for qemu-devel@nongnu.org; Wed, 15 Oct 2014 08:38:38 -0400 Date: Wed, 15 Oct 2014 14:38:33 +0200 From: Stefan Hajnoczi Message-ID: <20141015123833.GA2852@stefanha-thinkpad.redhat.com> References: <1413376170-50093-1-git-send-email-imammedo@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="BOKacYhQ+x31HxR3" Content-Disposition: inline In-Reply-To: <1413376170-50093-1-git-send-email-imammedo@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3] glib: add compatibility interface for g_get_monotonic_time() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, dgilbert@redhat.com --BOKacYhQ+x31HxR3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 15, 2014 at 02:29:30PM +0200, Igor Mammedov wrote: > From: Stefan Hajnoczi >=20 > This patch fixes compilation errors when building against glib <2.28.0 > due to the missing g_get_monotonic_time() function. >=20 > The compilation error in tests/libqos/virtio.c was introduced in commit > 70556264a89a268efba1d7e8e341adcdd7881eb4 ("libqos: use microseconds > instead of iterations for virtio timeout"). >=20 > Add a simple g_get_monotonic_time() implementation to glib-compat.h > based on code from vhost-user-test.c. >=20 > Signed-off-by: Stefan Hajnoczi > Signed-off-by: Igor Mammedov > --- > v3: include glib-compat.h into libqtest.h to fix another build breakage (= Peter) > v2: fix build break beacuse of missing G_TIME_SPAN_SECOND in header > --- > include/glib-compat.h | 19 +++++++++++++++++++ > tests/libqtest.h | 1 + > tests/vhost-user-test.c | 23 +---------------------- > 3 files changed, 21 insertions(+), 22 deletions(-) Thanks Igor and Peter. I didn't have a machine with old glib for testing :(. Stefan --BOKacYhQ+x31HxR3 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUPmrJAAoJEJykq7OBq3PIOc0IAIED4d3wCjVg9KZ3sIil6aaT u7c3vzKiTfpP8d2xd05mJ+ouerUpEmZ8+TECP+kZ8+f0k/BiFUbl7bAMQbjCXr6h pHYMzr6kMgP2SDCY/+AMVEMFniTNULwoB9TJ4l1wTVD5OrFjAMXXEwd4YHl+yE6C 7yAClLRPeYAmYRltWrbV1Rf1YNNUqNh77OoC3Tb2nwmoU4xc7mlkmOQfcSIjdsql ogYYK0/GwWJ7pa0kyoywGM/Gz87RI3LBe8ywX97XOqGi1A62nlmgf/YsbT2nLJgw 8Tm04IL3u4ZQXNwrKNQskSHtKW2i5GGoexNwUhgyGlmU7WcCuJaHA4jHW27AS68= =V+Xk -----END PGP SIGNATURE----- --BOKacYhQ+x31HxR3--