From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33996) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XePlO-0004T7-OC for qemu-devel@nongnu.org; Wed, 15 Oct 2014 10:41:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XePlL-0002Mk-1W for qemu-devel@nongnu.org; Wed, 15 Oct 2014 10:41:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37307) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XePlK-0002Me-P7 for qemu-devel@nongnu.org; Wed, 15 Oct 2014 10:41:14 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9FEfD0E008041 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 15 Oct 2014 10:41:14 -0400 Date: Wed, 15 Oct 2014 15:41:10 +0100 From: "Daniel P. Berrange" Message-ID: <20141015144110.GF3741@redhat.com> References: <1413375585-20301-1-git-send-email-kraxel@redhat.com> <20141015123237.GB3741@redhat.com> <1413383387.4213.7.camel@nilsson.home.kraxel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1413383387.4213.7.camel@nilsson.home.kraxel.org> Subject: Re: [Qemu-devel] [PATCH 0/6] vnc: add support for multiple vnc server instances. Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org On Wed, Oct 15, 2014 at 04:29:47PM +0200, Gerd Hoffmann wrote: > Hi, > > > > To be done: monitor support. I think the best way to handle this is to > > > introduce a new command to query vnc server state, which returns a list > > > of vnc servers but otherwise works like "query-vnc". Alternative > > > approach would be to add a optional 'id=' parameter to query-vnc, but > > > then you'll need a new list-vnc command. > > > > > > Opinions on this? > > > > I don't think it makes a whole lot of difference really. Either way > > mgmt apps like libvirt will need updating to deal with the new monitor > > commands. > > One thing that comes do mind is that if we do a completely new command > we can easily fix any shortcomings of the existing query-vnc command. > > The listening address could be changed to be a *list* of addresses, > allowing to notify libvirt about multiple listening sockets. One ipv4, > one ipv6 being a use case. That sounds like a good reason. I can even imagine in the future there could be multiple IPv4 and multiple IPv6 addresses per VNC server. eg if the host has many NICs present and we only want to listen on a subset of them we might want to pass multiple IPv4 addresses to QEMU on the CLI. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|