From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35065) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XegWt-00075w-W8 for qemu-devel@nongnu.org; Thu, 16 Oct 2014 04:35:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XegWn-0000SU-CE for qemu-devel@nongnu.org; Thu, 16 Oct 2014 04:35:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:2213) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XegWn-0000Rz-4S for qemu-devel@nongnu.org; Thu, 16 Oct 2014 04:35:21 -0400 Date: Thu, 16 Oct 2014 09:35:02 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20141016083501.GG2590@work-vm> References: <1412358473-31398-1-git-send-email-dgilbert@redhat.com> <1412358473-31398-17-git-send-email-dgilbert@redhat.com> <543F814F.6030105@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <543F814F.6030105@huawei.com> Subject: Re: [Qemu-devel] [PATCH v4 16/47] Return path: Source handling of return path List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: zhanghailiang Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, lilei@linux.vnet.ibm.com, quintela@redhat.com, cristian.klein@cs.umu.se, qemu-devel@nongnu.org, amit.shah@redhat.com, yanghy@cn.fujitsu.com * zhanghailiang (zhang.zhanghailiang@huawei.com) wrote: > >+ case MIG_RPCOMM_ACK: > >+ tmp32 = be32_to_cpup((uint32_t *)buf); > >+ DPRINTF("RP: Received ACK 0x%x", tmp32); > >+ atomic_xchg(&ms->rp_state.latest_ack, tmp32); > > I didn't see *ms->rp_state.latest_ack* been used elsewhere, what's it used for?;) Nothing currently; I've used the REQ/ACK as debug at the moment; I was thinking that someone might want to wait on an ack being received before carrying on; but hadn't actually needed it in postcopy. Dave -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK