From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52922) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XgCnT-0001Or-I2 for qemu-devel@nongnu.org; Mon, 20 Oct 2014 09:14:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XgCnN-0007KE-9N for qemu-devel@nongnu.org; Mon, 20 Oct 2014 09:14:51 -0400 Received: from lputeaux-656-01-25-125.w80-12.abo.wanadoo.fr ([80.12.84.125]:51695 helo=paradis.irqsave.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XgCnN-0007K3-0e for qemu-devel@nongnu.org; Mon, 20 Oct 2014 09:14:45 -0400 Date: Mon, 20 Oct 2014 15:11:53 +0200 From: =?iso-8859-1?Q?Beno=EEt?= Canet Message-ID: <20141020131153.GC13245@irqsave.net> References: <1413805631-11626-1-git-send-email-pl@kamp.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1413805631-11626-1-git-send-email-pl@kamp.de> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] block: qemu-iotests change _supported_proto to file once more. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven Cc: kwolf@redhat.com, famz@redhat.com, hutao@cn.fujitsu.com, jcody@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com, lersek@redhat.com The Monday 20 Oct 2014 =E0 13:47:11 (+0200), Peter Lieven wrote : > In preparation to possible automatic regression and performance > testing for the block layer I found that the iotests don't work > for all protocols anymore. >=20 > In commit 1f7bf7d0 I started to change supported protocols from > generic to file for various tests. Unfortunately, some tests > added in the meantime again carry generic protocol altough they > can only work with file because they require local file access. >=20 > The other way around for some tests that only support file I added > NFS protocol after confirming they work. >=20 > Signed-off-by: Peter Lieven > --- > tests/qemu-iotests/075 | 2 +- > tests/qemu-iotests/076 | 2 +- > tests/qemu-iotests/078 | 2 +- > tests/qemu-iotests/079 | 2 +- > tests/qemu-iotests/080 | 2 +- > tests/qemu-iotests/081 | 2 +- > tests/qemu-iotests/082 | 2 +- > tests/qemu-iotests/084 | 2 +- > tests/qemu-iotests/086 | 2 +- > tests/qemu-iotests/088 | 2 +- > tests/qemu-iotests/090 | 2 +- > tests/qemu-iotests/092 | 2 +- > tests/qemu-iotests/103 | 2 +- > 13 files changed, 13 insertions(+), 13 deletions(-) >=20 > diff --git a/tests/qemu-iotests/075 b/tests/qemu-iotests/075 > index 40032c5..6117660 100755 > --- a/tests/qemu-iotests/075 > +++ b/tests/qemu-iotests/075 > @@ -39,7 +39,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15 > . ./common.filter > =20 > _supported_fmt cloop > -_supported_proto generic > +_supported_proto file > _supported_os Linux > =20 > block_size_offset=3D128 > diff --git a/tests/qemu-iotests/076 b/tests/qemu-iotests/076 > index b614a7d..bc47457 100755 > --- a/tests/qemu-iotests/076 > +++ b/tests/qemu-iotests/076 > @@ -39,7 +39,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15 > . ./common.filter > =20 > _supported_fmt parallels > -_supported_proto generic > +_supported_proto file > _supported_os Linux > =20 > tracks_offset=3D$((0x1c)) > diff --git a/tests/qemu-iotests/078 b/tests/qemu-iotests/078 > index d4d6da7..7be2c3f 100755 > --- a/tests/qemu-iotests/078 > +++ b/tests/qemu-iotests/078 > @@ -39,7 +39,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15 > . ./common.filter > =20 > _supported_fmt bochs > -_supported_proto generic > +_supported_proto file > _supported_os Linux > =20 > catalog_size_offset=3D$((0x48)) > diff --git a/tests/qemu-iotests/079 b/tests/qemu-iotests/079 > index 2142bbb..6613cfb 100755 > --- a/tests/qemu-iotests/079 > +++ b/tests/qemu-iotests/079 > @@ -39,7 +39,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15 > . ./common.filter > =20 > _supported_fmt qcow2 > -_supported_proto file > +_supported_proto file nfs > _supported_os Linux > =20 > function test_qemu_img() > diff --git a/tests/qemu-iotests/080 b/tests/qemu-iotests/080 > index 6b3a3e7..9de337c 100755 > --- a/tests/qemu-iotests/080 > +++ b/tests/qemu-iotests/080 > @@ -40,7 +40,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15 > . ./common.filter > =20 > _supported_fmt qcow2 > -_supported_proto generic > +_supported_proto file > _supported_os Linux > =20 > header_size=3D104 > diff --git a/tests/qemu-iotests/081 b/tests/qemu-iotests/081 > index 7ae4be2..ed3c29e 100755 > --- a/tests/qemu-iotests/081 > +++ b/tests/qemu-iotests/081 > @@ -41,7 +41,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15 > . ./common.filter > =20 > _supported_fmt raw > -_supported_proto generic > +_supported_proto file > _supported_os Linux > =20 > function do_run_qemu() > diff --git a/tests/qemu-iotests/082 b/tests/qemu-iotests/082 > index 910b13e..e64de27 100755 > --- a/tests/qemu-iotests/082 > +++ b/tests/qemu-iotests/082 > @@ -39,7 +39,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15 > . ./common.filter > =20 > _supported_fmt qcow2 > -_supported_proto file > +_supported_proto file nfs > _supported_os Linux > =20 > function run_qemu_img() > diff --git a/tests/qemu-iotests/084 b/tests/qemu-iotests/084 > index ae33c2c..2712c02 100755 > --- a/tests/qemu-iotests/084 > +++ b/tests/qemu-iotests/084 > @@ -41,7 +41,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15 > =20 > # This tests vdi-specific header fields > _supported_fmt vdi > -_supported_proto generic > +_supported_proto file > _supported_os Linux > =20 > size=3D64M > diff --git a/tests/qemu-iotests/086 b/tests/qemu-iotests/086 > index d9a80cf..234eb9a 100755 > --- a/tests/qemu-iotests/086 > +++ b/tests/qemu-iotests/086 > @@ -39,7 +39,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15 > . ./common.filter > =20 > _supported_fmt qcow2 > -_supported_proto file > +_supported_proto file nfs > _supported_os Linux > =20 > function run_qemu_img() > diff --git a/tests/qemu-iotests/088 b/tests/qemu-iotests/088 > index c09adf8..f9c3129 100755 > --- a/tests/qemu-iotests/088 > +++ b/tests/qemu-iotests/088 > @@ -40,7 +40,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15 > . ./common.filter > =20 > _supported_fmt vpc > -_supported_proto generic > +_supported_proto file > _supported_os Linux > =20 > offset_block_size=3D$((512 + 32)) > diff --git a/tests/qemu-iotests/090 b/tests/qemu-iotests/090 > index 8d032f8..70b5a6f 100755 > --- a/tests/qemu-iotests/090 > +++ b/tests/qemu-iotests/090 > @@ -39,7 +39,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15 > . ./common.filter > =20 > _supported_fmt qcow2 > -_supported_proto file > +_supported_proto file nfs > _supported_os Linux > =20 > IMG_SIZE=3D128K > diff --git a/tests/qemu-iotests/092 b/tests/qemu-iotests/092 > index a8c0c9c..52c529b 100755 > --- a/tests/qemu-iotests/092 > +++ b/tests/qemu-iotests/092 > @@ -40,7 +40,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15 > . ./common.filter > =20 > _supported_fmt qcow > -_supported_proto generic > +_supported_proto file > _supported_os Linux > =20 > offset_backing_file_offset=3D8 > diff --git a/tests/qemu-iotests/103 b/tests/qemu-iotests/103 > index 0f1dc9f..ccab551 100755 > --- a/tests/qemu-iotests/103 > +++ b/tests/qemu-iotests/103 > @@ -39,7 +39,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15 > . ./common.filter > =20 > _supported_fmt qcow2 > -_supported_proto file > +_supported_proto file nfs > _supported_os Linux > =20 > IMG_SIZE=3D64K > --=20 > 1.7.9.5 >=20 >=20 Seems legit. Reviewed-by: Beno=EEt Canet