qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Markus Armbruster <armbru@redhat.com>,
	QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] get_maintainer.pl: Default to --no-git-fallback
Date: Mon, 20 Oct 2014 17:15:48 +0300	[thread overview]
Message-ID: <20141020141548.GA11062@redhat.com> (raw)
In-Reply-To: <CAFEAcA_UxfVow0m2xu4+r8S-nK2Pb-jyNxmWhvXXP1G9V4Nerg@mail.gmail.com>

On Mon, Oct 20, 2014 at 03:04:44PM +0100, Peter Maydell wrote:
> On 20 October 2014 10:19, Markus Armbruster <armbru@redhat.com> wrote:
> > Contributors rely on this script to find maintainers to copy.  The
> > script falls back to git when no exact MAINTAINERS pattern matches.
> > When that happens, recent contributors get copied, which tends not be
> > particularly useful.  Some contributors find it even annoying.
> >
> > Flip the default to "don't fall back to git".  Use --git-fallback to
> > ask it to fall back to git.
> >
> > Signed-off-by: Markus Armbruster <armbru@redhat.com>
> 
> Good idea.
> 
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> 
> -- PMM

What do you want to happen in this case?
Won't this cause even more patches to fall to the floor?

The benefit seems marginal, the risk high.

I would be OK with this if you also go over history
and assign maintainers to all core files which lack
maintainers listed in MAINTAINERS.

I'm yet to see contributors who are annoyed but we
can always blacklist specific people.

-- 
MST

  reply	other threads:[~2014-10-20 14:12 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-20  9:19 [Qemu-devel] [PATCH] get_maintainer.pl: Default to --no-git-fallback Markus Armbruster
2014-10-20 12:27 ` Don Slutz
2014-10-20 14:04 ` Peter Maydell
2014-10-20 14:15   ` Michael S. Tsirkin [this message]
2014-10-20 14:19     ` Peter Maydell
2014-10-20 19:03       ` Michael S. Tsirkin
2014-10-20 20:10         ` Don Slutz
2014-10-20 21:07           ` Peter Maydell
2014-10-21  9:31         ` Markus Armbruster
2014-10-21 10:00           ` Michael S. Tsirkin
2014-10-21 12:22             ` Markus Armbruster
2014-10-21 12:38               ` Michael S. Tsirkin
2014-10-21 13:29                 ` Markus Armbruster
2014-10-21 22:30                   ` Michael S. Tsirkin
2014-10-22  6:39                     ` Markus Armbruster
2014-10-22  7:01                       ` Michael S. Tsirkin
2014-10-22  8:10                         ` Thomas Huth
2014-10-22  8:18                           ` Michael S. Tsirkin
2014-10-20 18:38     ` Paolo Bonzini
2014-10-21 11:09       ` Gerd Hoffmann
2014-10-21 11:15         ` Michael S. Tsirkin
2014-10-21 11:23           ` Gerd Hoffmann
2014-10-21 11:35             ` Michael S. Tsirkin
2014-10-21 13:34       ` Markus Armbruster
2014-10-21 13:39         ` Paolo Bonzini
2014-10-21 13:46         ` Kirill Batuzov
2014-10-21 22:31         ` Michael S. Tsirkin
2014-10-22  7:01           ` Markus Armbruster
2014-10-22  7:12             ` Michael S. Tsirkin
2014-10-22  7:45               ` Paolo Bonzini
2014-10-22  8:03               ` Markus Armbruster
2014-10-22  8:29                 ` Michael S. Tsirkin
2014-10-22 19:25                   ` Don Slutz
2014-10-21  6:22     ` Thomas Huth
2014-10-21  9:19     ` Markus Armbruster
2014-10-21 13:40       ` Kirill Batuzov
2014-10-21 14:15         ` Markus Armbruster
2014-10-21 22:35           ` Michael S. Tsirkin
2014-10-20 15:06 ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141020141548.GA11062@redhat.com \
    --to=mst@redhat.com \
    --cc=armbru@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).