From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41667) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XgDh7-0000Kr-8A for qemu-devel@nongnu.org; Mon, 20 Oct 2014 10:12:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XgDh2-0005zH-5g for qemu-devel@nongnu.org; Mon, 20 Oct 2014 10:12:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8003) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XgDh1-0005yz-UD for qemu-devel@nongnu.org; Mon, 20 Oct 2014 10:12:16 -0400 Date: Mon, 20 Oct 2014 17:15:48 +0300 From: "Michael S. Tsirkin" Message-ID: <20141020141548.GA11062@redhat.com> References: <1413796790-30579-1-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH] get_maintainer.pl: Default to --no-git-fallback List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Markus Armbruster , QEMU Developers On Mon, Oct 20, 2014 at 03:04:44PM +0100, Peter Maydell wrote: > On 20 October 2014 10:19, Markus Armbruster wrote: > > Contributors rely on this script to find maintainers to copy. The > > script falls back to git when no exact MAINTAINERS pattern matches. > > When that happens, recent contributors get copied, which tends not be > > particularly useful. Some contributors find it even annoying. > > > > Flip the default to "don't fall back to git". Use --git-fallback to > > ask it to fall back to git. > > > > Signed-off-by: Markus Armbruster > > Good idea. > > Reviewed-by: Peter Maydell > > -- PMM What do you want to happen in this case? Won't this cause even more patches to fall to the floor? The benefit seems marginal, the risk high. I would be OK with this if you also go over history and assign maintainers to all core files which lack maintainers listed in MAINTAINERS. I'm yet to see contributors who are annoyed but we can always blacklist specific people. -- MST