From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33646) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XgF02-0007LT-K2 for qemu-devel@nongnu.org; Mon, 20 Oct 2014 11:36:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XgEzx-00035t-VY for qemu-devel@nongnu.org; Mon, 20 Oct 2014 11:35:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:15957) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XgEzx-00035j-Mw for qemu-devel@nongnu.org; Mon, 20 Oct 2014 11:35:53 -0400 Date: Mon, 20 Oct 2014 17:00:39 +0200 From: Igor Mammedov Message-ID: <20141020170039.69915d62@nial.usersys.redhat.com> In-Reply-To: <1412907367-28297-7-git-send-email-guz.fnst@cn.fujitsu.com> References: <1412907367-28297-1-git-send-email-guz.fnst@cn.fujitsu.com> <1412907367-28297-7-git-send-email-guz.fnst@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V5 6/8] qom/cpu: remove the unused CPU hot-plug notifier List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gu Zheng Cc: chen.fan.fnst@cn.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, qemu-devel@nongnu.org, afaerber@suse.de, tangchen@cn.fujitsu.com On Fri, 10 Oct 2014 10:16:05 +0800 Gu Zheng wrote: > Remove the unused CPU hot-plug notifier. > > Signed-off-by: Gu Zheng Reviewed-by: Igor Mammedov > --- > v5: > -delete the caller of notifier_list_notify() in this patch. > > include/sysemu/sysemu.h | 3 --- > qom/cpu.c | 10 ---------- > 2 files changed, 0 insertions(+), 13 deletions(-) > > diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h > index d8539fd..acfe494 100644 > --- a/include/sysemu/sysemu.h > +++ b/include/sysemu/sysemu.h > @@ -183,9 +183,6 @@ void do_pci_device_hot_remove(Monitor *mon, const QDict *qdict); > /* generic hotplug */ > void drive_hot_add(Monitor *mon, const QDict *qdict); > > -/* CPU hotplug */ > -void qemu_register_cpu_added_notifier(Notifier *notifier); > - > /* pcie aer error injection */ > void pcie_aer_inject_error_print(Monitor *mon, const QObject *data); > int do_pcie_aer_inject_error(Monitor *mon, > diff --git a/qom/cpu.c b/qom/cpu.c > index 0ec3337..79d2228 100644 > --- a/qom/cpu.c > +++ b/qom/cpu.c > @@ -107,15 +107,6 @@ static void cpu_common_get_memory_mapping(CPUState *cpu, > error_setg(errp, "Obtaining memory mappings is unsupported on this CPU."); > } > > -/* CPU hot-plug notifiers */ > -static NotifierList cpu_added_notifiers = > - NOTIFIER_LIST_INITIALIZER(cpu_add_notifiers); > - > -void qemu_register_cpu_added_notifier(Notifier *notifier) > -{ > - notifier_list_add(&cpu_added_notifiers, notifier); > -} > - > void cpu_reset_interrupt(CPUState *cpu, int mask) > { > cpu->interrupt_request &= ~mask; > @@ -312,7 +303,6 @@ static void cpu_common_realizefn(DeviceState *dev, Error **errp) > > if (dev->hotplugged) { > cpu_synchronize_post_init(cpu); > - notifier_list_notify(&cpu_added_notifiers, dev); > cpu_resume(cpu); > } > }