From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58403) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XgSqh-0008G4-3U for qemu-devel@nongnu.org; Tue, 21 Oct 2014 02:23:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XgSqZ-0001uF-FM for qemu-devel@nongnu.org; Tue, 21 Oct 2014 02:23:15 -0400 Received: from e06smtp10.uk.ibm.com ([195.75.94.106]:36007) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XgSqZ-0001tv-5r for qemu-devel@nongnu.org; Tue, 21 Oct 2014 02:23:07 -0400 Received: from /spool/local by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 21 Oct 2014 07:23:03 +0100 Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 090062190045 for ; Tue, 21 Oct 2014 07:22:38 +0100 (BST) Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id s9L6N1kk16253232 for ; Tue, 21 Oct 2014 06:23:01 GMT Received: from d06av02.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s9L6N0X2012794 for ; Tue, 21 Oct 2014 00:23:01 -0600 Date: Tue, 21 Oct 2014 08:22:57 +0200 From: Thomas Huth Message-ID: <20141021082257.169e04ae@oc7435384737.ibm.com> In-Reply-To: <20141020141548.GA11062@redhat.com> References: <1413796790-30579-1-git-send-email-armbru@redhat.com> <20141020141548.GA11062@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] get_maintainer.pl: Default to --no-git-fallback List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Peter Maydell , Markus Armbruster , QEMU Developers On Mon, 20 Oct 2014 17:15:48 +0300 "Michael S. Tsirkin" wrote: > On Mon, Oct 20, 2014 at 03:04:44PM +0100, Peter Maydell wrote: > > On 20 October 2014 10:19, Markus Armbruster wrote: > > > Contributors rely on this script to find maintainers to copy. The > > > script falls back to git when no exact MAINTAINERS pattern matches. > > > When that happens, recent contributors get copied, which tends not be > > > particularly useful. Some contributors find it even annoying. > > > > > > Flip the default to "don't fall back to git". Use --git-fallback to > > > ask it to fall back to git. > > > > > > Signed-off-by: Markus Armbruster > > > > Good idea. > > > > Reviewed-by: Peter Maydell > > > > -- PMM > > What do you want to happen in this case? > Won't this cause even more patches to fall to the floor? > > The benefit seems marginal, the risk high. Well, IMHO, at least the current behaviour if git-fallback seems to be a little bit too easygoing: I already got mails just because I once reviewed a patch in the past and thus got listed with the "Reviewed-by:" tag. I would not expect that behaviour when I run a "get_maintainers" script (it's not called "get_reviewers", is it?). Maybe you could at least remove the "Reviewed-by:" and "Acked-by:" from the --git-fallback option so that it only checks for the SOBs? Thomas