From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60256)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XgXfx-0004qj-6J
	for qemu-devel@nongnu.org; Tue, 21 Oct 2014 07:32:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XgXfs-0004ES-9M
	for qemu-devel@nongnu.org; Tue, 21 Oct 2014 07:32:29 -0400
Received: from mx1.redhat.com ([209.132.183.28]:53537)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XgXfs-0004DM-1o
	for qemu-devel@nongnu.org; Tue, 21 Oct 2014 07:32:24 -0400
Date: Tue, 21 Oct 2014 14:35:52 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20141021113552.GA23316@redhat.com>
References: <1413796790-30579-1-git-send-email-armbru@redhat.com>
	<CAFEAcA_UxfVow0m2xu4+r8S-nK2Pb-jyNxmWhvXXP1G9V4Nerg@mail.gmail.com>
	<20141020141548.GA11062@redhat.com> <544556A1.3020405@redhat.com>
	<1413889759.14632.17.camel@nilsson.home.kraxel.org>
	<20141021111553.GA23118@redhat.com>
	<1413890629.14632.19.camel@nilsson.home.kraxel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1413890629.14632.19.camel@nilsson.home.kraxel.org>
Subject: Re: [Qemu-devel] [PATCH] get_maintainer.pl: Default to
 --no-git-fallback
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>, Paolo Bonzini <pbonzini@redhat.com>, Markus Armbruster <armbru@redhat.com>, Peter Maydell <peter.maydell@linaro.org>

On Tue, Oct 21, 2014 at 01:23:49PM +0200, Gerd Hoffmann wrote:
>   Hi,
> 
> > > How about making "get_maintainer.pl --git-fallback" actually do what it
> > > says?  Right now git it *not* used as fallback, it goes to git log
> > > unconditionally, even if there are hits in MAINTAINERS ...
> > 
> > It does?
> > 
> > How do you reproduce this behaviour?
> > 
> > $ ./scripts/get_maintainer.pl -f vl.c
> > Anthony Liguori <aliguori@amazon.com> (supporter:Main loop)
> > 
> > Seems to stop if it sees a maintainer.
> 
> nilsson kraxel ~/projects/qemu (usb.work)# scripts/get_maintainer.pl -f
> ui/vnc.c
> Anthony Liguori <aliguori@amazon.com> (odd fixer:Graphics)
> Gerd Hoffmann <kraxel@redhat.com> (odd
> fixer:Graphics,commit_signer:21/24=88%)
> Peter Lieven <pl@kamp.de> (commit_signer:12/24=50%)
> Wenchao Xia <wenchaoqemu@gmail.com> (commit_signer:7/24=29%)
> Markus Armbruster <armbru@redhat.com> (commit_signer:3/24=12%)
> Luiz Capitulino <lcapitulino@redhat.com> (commit_signer:3/24=12%)
> 
> Maybe it depends on maintainer status ...
> 
> cheers,
>   Gerd
> 

Yes and that's a bug.
Thanks for the report.
Patch send, maybe that will be enough.


-- 
MST