From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55844)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XghuN-00050A-Fz
	for qemu-devel@nongnu.org; Tue, 21 Oct 2014 18:28:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XghuF-0006mj-Qq
	for qemu-devel@nongnu.org; Tue, 21 Oct 2014 18:28:03 -0400
Received: from mx1.redhat.com ([209.132.183.28]:3193)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XghuF-0006lo-GS
	for qemu-devel@nongnu.org; Tue, 21 Oct 2014 18:27:55 -0400
Date: Wed, 22 Oct 2014 01:31:29 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20141021223129.GD18051@redhat.com>
References: <1413796790-30579-1-git-send-email-armbru@redhat.com>
	<CAFEAcA_UxfVow0m2xu4+r8S-nK2Pb-jyNxmWhvXXP1G9V4Nerg@mail.gmail.com>
	<20141020141548.GA11062@redhat.com> <544556A1.3020405@redhat.com>
	<87r3y1tukp.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87r3y1tukp.fsf@blackfin.pond.sub.org>
Subject: Re: [Qemu-devel] [PATCH] get_maintainer.pl: Default to
 --no-git-fallback
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>, Peter Maydell <peter.maydell@linaro.org>

On Tue, Oct 21, 2014 at 03:34:46PM +0200, Markus Armbruster wrote:
> Paolo Bonzini <pbonzini@redhat.com> writes:
> 
> > On 10/20/2014 04:15 PM, Michael S. Tsirkin wrote:
> >> What do you want to happen in this case?
> >> Won't this cause even more patches to fall to the floor?
> >>
> >> The benefit seems marginal, the risk high.
> >
> > I agree with Michael.
> >
> > Can we detect if get_maintainer.pl is invoked as a cccmd, and in this
> > case default to --no-git-fallback?  If it is invoked manually, I would
> > like to show the committers (I will then cherry pick the right ones).
> 
> I don't like context-sensitive defaults.  Too much magic.
> 
> What about this: if get_maintainer.pl comes up empty, it points you to
> --git-fallback.

This is exactly what it's doing now :)