From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57349) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XgpJm-0003DS-MG for qemu-devel@nongnu.org; Wed, 22 Oct 2014 02:22:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XgpJh-0005Dp-Mj for qemu-devel@nongnu.org; Wed, 22 Oct 2014 02:22:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9674) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XgpJh-0005Dl-FZ for qemu-devel@nongnu.org; Wed, 22 Oct 2014 02:22:41 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9M6MebV029958 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 22 Oct 2014 02:22:40 -0400 Date: Wed, 22 Oct 2014 09:26:14 +0300 From: "Michael S. Tsirkin" Message-ID: <20141022062614.GB20771@redhat.com> References: <1413895032-10116-1-git-send-email-marcel.a@redhat.com> <5446D8DA.6000003@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5446D8DA.6000003@redhat.com> Subject: Re: [Qemu-devel] [PATCH] hw/pci: fixed crash when using rombar=0 for hotplugged devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: alex.williamson@redhat.com, qemu-devel@nongnu.org, Marcel Apfelbaum On Wed, Oct 22, 2014 at 12:06:18AM +0200, Paolo Bonzini wrote: > > > On 10/21/2014 02:37 PM, Marcel Apfelbaum wrote: > > ROM images must be loaded at startup. Usage of rombar=0 after that > > is not allowed, but should not crash QEMU. > > > > Check that the device is not hotplugged before trying to > > insert the rom file. > > I think it could also make sense to just ignore the option ROM and allow > the hotplug. > > Sooner or later we should drop the oldest compat machine types... > everything until 0.12 probably could go. > > Paolo Unfortunately, we made the mistake of exposing the rombar attribute to management. See rom element at http://libvirt.org/formatdomain.html#elementsHostDevSubsys and in theory some users might have configured rombar=off but set file to some value. I'd be OK with removing support for this combination, if we want the legacy fw cfg thing, we should have a separate attribute. But I'd like someone from libvirt to OK this ... Eric? > > Signed-off-by: Marcel Apfelbaum > > --- > > hw/pci/pci.c | 11 ++++++++++- > > 1 file changed, 10 insertions(+), 1 deletion(-) > > > > diff --git a/hw/pci/pci.c b/hw/pci/pci.c > > index 6ce75aa..3907c90 100644 > > --- a/hw/pci/pci.c > > +++ b/hw/pci/pci.c > > @@ -1776,7 +1776,12 @@ static int pci_qdev_init(DeviceState *qdev) > > pci_dev->romfile = g_strdup(pc->romfile); > > is_default_rom = true; > > } > > - pci_add_option_rom(pci_dev, is_default_rom); > > + > > + rc = pci_add_option_rom(pci_dev, is_default_rom); > > + if (rc != 0) { > > + pci_unregister_device(DEVICE(pci_dev)); > > + return rc; > > + } > > > > return 0; > > } > > @@ -1940,6 +1945,10 @@ static int pci_add_option_rom(PCIDevice *pdev, bool is_default_rom) > > if (class == 0x0300) { > > rom_add_vga(pdev->romfile); > > } else { > > + if (DEVICE(pdev)->hotplugged) { > > + error_report("PCI: rombar can't be 0 for hotplugged devices!"); > > + return -1; > > + } > > rom_add_option(pdev->romfile, -1); > > } > > return 0; > >