From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34462)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Xgps8-0004Z3-GP
	for qemu-devel@nongnu.org; Wed, 22 Oct 2014 02:58:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Xgps3-0007sC-Df
	for qemu-devel@nongnu.org; Wed, 22 Oct 2014 02:58:16 -0400
Received: from mx1.redhat.com ([209.132.183.28]:2352)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Xgps3-0007s8-5t
	for qemu-devel@nongnu.org; Wed, 22 Oct 2014 02:58:11 -0400
Date: Wed, 22 Oct 2014 10:01:43 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20141022070143.GA23513@redhat.com>
References: <20141020141548.GA11062@redhat.com>
	<CAFEAcA_c2-qJ6PBEdLnCSFg6yy4EzXzy_17BHLoZQhwD=WGDyw@mail.gmail.com>
	<20141020190358.GA12441@redhat.com>
	<87vbnddb1b.fsf@blackfin.pond.sub.org>
	<20141021100047.GA18294@redhat.com>
	<87iojdy5m6.fsf@blackfin.pond.sub.org>
	<20141021123848.GA23765@redhat.com>
	<87vbndtutx.fsf@blackfin.pond.sub.org>
	<20141021223032.GC18051@redhat.com>
	<87a94oehfk.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87a94oehfk.fsf@blackfin.pond.sub.org>
Subject: Re: [Qemu-devel] [PATCH] get_maintainer.pl: Default to
 --no-git-fallback
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, QEMU Developers <qemu-devel@nongnu.org>

On Wed, Oct 22, 2014 at 08:39:59AM +0200, Markus Armbruster wrote:
> "Michael S. Tsirkin" <mst@redhat.com> writes:
> 
> > On Tue, Oct 21, 2014 at 03:29:14PM +0200, Markus Armbruster wrote:
> >> "Michael S. Tsirkin" <mst@redhat.com> writes:
> >> 
> >> > On Tue, Oct 21, 2014 at 02:22:41PM +0200, Markus Armbruster wrote:
> [...]
> >> >> My patch to get_maintainers.pl triggered a whole thread, while the
> >> >> message I sent on MAINTAINERS coverage got just one reply so far, and
> >> >> even that one's really just about get_maintainers.pl.  Disappointing.
> >> >> Looks like we're still looking for an easy technical fix.  I doubt there
> >> >> is one.
> >> >
> >> > At least for myself, that's because I'm Cc'd directly on the patch
> >> > but not on the MAINTAINERS coverage mail.
> >> > And that's ... because get_maintainers picks my mail from git?
> >> >
> >> > See how it's useful now?
> >> 
> >> Except that's not what happened.
> >> 
> >>     $ scripts/get_maintainer.pl --git-fallback -f scripts/get_maintainer.pl 
> >> 
> >> No output.  I picked you from git-log manually.
> >
> > Weird.
> > It works for me:
> >  ./scripts/get_maintainer.pl -f scripts/get_maintainer.pl 
> > "Michael S. Tsirkin" <mst@redhat.com> (commit_signer:1/1=100%)
> >
> > Maybe --git-fallback is broken?
> 
> I tried on master (i.e. without my patch, clean tree, with and without
> --git-fallback.  Just tried it again, same result.

Well ... I don't know why.
It's clearly a bug.
Different perl version? Different git version?

Can you try tracing it?
Does it exec git?

> > Another reason to defer this patch ...
> 
> Can't see why.

So we can debug and fix --git-fallback.


>  But I'm content to defer it until the patch traffic
> triggered by this discussion quiets down, so we can reevaluate.
> 
> [...]