From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35648) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xgq30-0006zp-Hi for qemu-devel@nongnu.org; Wed, 22 Oct 2014 03:09:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xgq2v-0002Fp-PH for qemu-devel@nongnu.org; Wed, 22 Oct 2014 03:09:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28413) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xgq2v-0002Fc-H5 for qemu-devel@nongnu.org; Wed, 22 Oct 2014 03:09:25 -0400 Date: Wed, 22 Oct 2014 10:12:57 +0300 From: "Michael S. Tsirkin" Message-ID: <20141022071257.GA24952@redhat.com> References: <1413796790-30579-1-git-send-email-armbru@redhat.com> <20141020141548.GA11062@redhat.com> <544556A1.3020405@redhat.com> <87r3y1tukp.fsf@blackfin.pond.sub.org> <20141021223129.GD18051@redhat.com> <8738agegfv.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8738agegfv.fsf@blackfin.pond.sub.org> Subject: Re: [Qemu-devel] [PATCH] get_maintainer.pl: Default to --no-git-fallback List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Paolo Bonzini , QEMU Developers , Peter Maydell On Wed, Oct 22, 2014 at 09:01:24AM +0200, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > On Tue, Oct 21, 2014 at 03:34:46PM +0200, Markus Armbruster wrote: > >> Paolo Bonzini writes: > >> > >> > On 10/20/2014 04:15 PM, Michael S. Tsirkin wrote: > >> >> What do you want to happen in this case? > >> >> Won't this cause even more patches to fall to the floor? > >> >> > >> >> The benefit seems marginal, the risk high. > >> > > >> > I agree with Michael. > >> > > >> > Can we detect if get_maintainer.pl is invoked as a cccmd, and in this > >> > case default to --no-git-fallback? If it is invoked manually, I would > >> > like to show the committers (I will then cherry pick the right ones). > >> > >> I don't like context-sensitive defaults. Too much magic. > >> > >> What about this: if get_maintainer.pl comes up empty, it points you to > >> --git-fallback. > > > > This is exactly what it's doing now :) > > Nope. This is what it's doing now: > > $ scripts/get_maintainer.pl -f util/cutils.c > Luiz Capitulino (commit_signer:1/2=50%) > Eric Blake (commit_signer:1/2=50%) > Alexey Kardashevskiy (commit_signer:1/2=50%) > Laszlo Ersek (commit_signer:1/2=50%) > Amit Shah (commit_signer:1/2=50%) > > A sufficiently seasoned contributor will spot the "commit_signer" tags, > and the output as a hint to find people to copy. In this particular > case, he'll recognize the hint is useless. Maybe he'll try something > like --git-since 2010 or --git-blame then. I'd just peruse git-log. > > A less seasoned contributor will blindly copy all five. I give up. What's the correct answer? I frankly don't know whom should one copy on this file. Fabrice? > This is what I'm proposing to do: > > $ scripts/get_maintainer.pl -f util/cutils.c > No maintainers found. > You may want to try --git-fallback to find recent contributors. > Do not blindly cc: them on patches! Use common sense. > > Perhaps round off with a link to a Wiki page with additional advice on > how to find people to copy. Let's start with that wiki page then. -- MST