From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36884)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XgqBp-0002G1-In
	for qemu-devel@nongnu.org; Wed, 22 Oct 2014 03:18:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XgqBk-0005PG-WE
	for qemu-devel@nongnu.org; Wed, 22 Oct 2014 03:18:37 -0400
Received: from mx1.redhat.com ([209.132.183.28]:52203)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XgqBk-0005P8-Ok
	for qemu-devel@nongnu.org; Wed, 22 Oct 2014 03:18:32 -0400
Date: Wed, 22 Oct 2014 10:22:04 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20141022072204.GA28193@redhat.com>
References: <1413891300-23369-1-git-send-email-mst@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1413891300-23369-1-git-send-email-mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] scripts/get_maintainer.pl: allow "odd
	fixes"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, Markus Armbruster <armbru@redhat.com>, Peter Maydell <peter.maydell@linaro.org>

On Tue, Oct 21, 2014 at 02:35:09PM +0300, Michael S. Tsirkin wrote:
> We have a bunch of modules in "Odd fixes"
> status, scripts/get_maintainer.pl ignores that.
> 
> Reported-by: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Cc: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

Actually, it does not ignore that.
What it does it list status as "odd fixer".

So this boils down to the fact that we use
"odd fixer" incorrectly.

I will apply this for now but maybe we should
change MAINTAINERS switching all "Odd fixes" to
"Maintained" and then revert this patch.

Thoughts?

> ---
>  scripts/get_maintainer.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> index 38334de..d5eee8c 100755
> --- a/scripts/get_maintainer.pl
> +++ b/scripts/get_maintainer.pl
> @@ -514,7 +514,7 @@ sub range_is_maintained {
>  	    my $type = $1;
>  	    my $value = $2;
>  	    if ($type eq 'S') {
> -		if ($value =~ /(maintain|support)/i) {
> +		if ($value =~ /(maintain|support|fix)/i) {
>  		    return 1;
>  		}
>  	    }
> -- 
> MST