From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43773)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eduardo.otubo@profitbricks.com>) id 1Xgquj-00050A-U0
	for qemu-devel@nongnu.org; Wed, 22 Oct 2014 04:05:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eduardo.otubo@profitbricks.com>) id 1Xgque-0002n5-V9
	for qemu-devel@nongnu.org; Wed, 22 Oct 2014 04:05:01 -0400
Received: from mail-wg0-f41.google.com ([74.125.82.41]:62791)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eduardo.otubo@profitbricks.com>) id 1Xgque-0002my-Q5
	for qemu-devel@nongnu.org; Wed, 22 Oct 2014 04:04:56 -0400
Received: by mail-wg0-f41.google.com with SMTP id b13so3013467wgh.0
	for <qemu-devel@nongnu.org>; Wed, 22 Oct 2014 01:04:55 -0700 (PDT)
Date: Wed, 22 Oct 2014 10:04:48 +0200
From: Eduardo Otubo <eduardo.otubo@profitbricks.com>
Message-ID: <20141022080447.GA23653@vader>
References: <1411132929-9691-1-git-send-email-eduardo.otubo@profitbricks.com>
	<CAFEAcA8kz7+3OvOrU_Bfzhq4HA4S3k9n0TpyutT4kEhi281new@mail.gmail.com>
	<CAEVwAuOTyUs3YeTqVoNA6n+KVkw_xA7ZcJ+HHdWno6iAav7zag@mail.gmail.com>
	<CAFEAcA-Ef8_QExyOiOqKwnVYecsdA_jXwP9ffn6A69rQnJzFNQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CAFEAcA-Ef8_QExyOiOqKwnVYecsdA_jXwP9ffn6A69rQnJzFNQ@mail.gmail.com>
Subject: Re: [Qemu-devel] [PULL 00/01] Adding new syscalls to seccomp
	whitelist
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>, Philipp Gesang <philipp.gesang@intra2net.com>

On Fri, Sep 19, 2014 at 08:11:14AM -0700, Peter Maydell wrote:
> On 19 September 2014 07:38, Eduardo Otubo
> <eduardo.otubo@profitbricks.com> wrote:
> > On Fri, Sep 19, 2014 at 4:15 PM, Peter Maydell <peter.maydell@linaro.org> wrote:
> >> ...how about fixing your compile errors on non-x86 platforms
> >> before adding more stuff here?
> >
> > Hm, indeed. I should have double checked that. Thanks for pointing that out.
> >
> > Philipp, can you fix this, please?
> 
> You have compile problems in current master as well. Your macros
> probably need to guard themselves on whether the syscall they're
> adding to the list actually exists on the host.
> (See bug https://bugs.launchpad.net/qemu/+bug/1363641 -- select
> doesn't exist as a syscall on all archs.)

The fix for that problem is upstream at libseccomp. The maintainer has
no plans yet to make a new release, though. Once he does a release nad
fix this issue, I'll go and resubmit this pull request.

Thanks,

-- 
Eduardo Otubo
ProfitBricks GmbH