From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43284)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XgqrH-0002mH-Ub
	for qemu-devel@nongnu.org; Wed, 22 Oct 2014 04:01:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XgqrB-0001ke-Uj
	for qemu-devel@nongnu.org; Wed, 22 Oct 2014 04:01:27 -0400
Received: from mx1.redhat.com ([209.132.183.28]:15570)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XgqrB-0001ka-LM
	for qemu-devel@nongnu.org; Wed, 22 Oct 2014 04:01:21 -0400
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9M81JVb017326
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Wed, 22 Oct 2014 04:01:20 -0400
Date: Wed, 22 Oct 2014 11:04:55 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20141022080455.GB4603@redhat.com>
References: <1413724361-29514-1-git-send-email-marcel.a@redhat.com>
	<1413963746.2376.13.camel@localhost.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1413963746.2376.13.camel@localhost.localdomain>
Subject: Re: [Qemu-devel] [PATCH] tests: fix acpi tables regeneration script
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: marcel.a@redhat.com
Cc: qemu-devel@nongnu.org

On Wed, Oct 22, 2014 at 10:42:26AM +0300, Marcel Apfelbaum wrote:
> On Sun, 2014-10-19 at 16:12 +0300, Marcel Apfelbaum wrote:
> > Commit: 501f28ca9db08e84819b26314525b6369e7704dd
> >     tests: rename acpi-test to bios-tables-test
> > 
> > modified acpi-test file from acpi-test.c to bios-tables-test.c.
> > However, the tables regeneration script was not modified
> > accordingly.
> > 
> > Fixed the test name also in rebuild-expected-aml.sh script.
> 
> Mini PING
> 
> Thanks,
> Marcel

Thanks!
I already merged an equivalent patch by Paolo.


> > 
> > Signed-off-by: Marcel Apfelbaum <marcel.a@redhat.com>
> > ---
> >  tests/acpi-test-data/rebuild-expected-aml.sh | 7 ++++---
> >  1 file changed, 4 insertions(+), 3 deletions(-)
> > 
> > diff --git a/tests/acpi-test-data/rebuild-expected-aml.sh b/tests/acpi-test-data/rebuild-expected-aml.sh
> > index ab98498..e7ce2b3 100755
> > --- a/tests/acpi-test-data/rebuild-expected-aml.sh
> > +++ b/tests/acpi-test-data/rebuild-expected-aml.sh
> > @@ -12,6 +12,7 @@
> >  # See the COPYING.LIB file in the top-level directory.
> >  
> >  qemu=
> > +acpi_test_path="tests/bios-tables-test"
> >  
> >  if [ -e x86_64-softmmu/qemu-system-x86_64 ]; then
> >      qemu="x86_64-softmmu/qemu-system-x86_64"
> > @@ -23,13 +24,13 @@ else
> >      exit 1;
> >  fi
> >  
> > -if [ ! -e "tests/acpi-test" ]; then
> > -    echo "Test: acpi-test is required! Run make check before this script."
> > +if [ ! -e $acpi_test_path ]; then
> > +    echo "Test: $acpi_test_path is required! Run make check before this script."
> >      echo "Run this script from the build directory."
> >      exit 1;
> >  fi
> >  
> > -TEST_ACPI_REBUILD_AML=y QTEST_QEMU_BINARY=$qemu tests/acpi-test
> > +TEST_ACPI_REBUILD_AML=y QTEST_QEMU_BINARY=$qemu $acpi_test_path
> >  
> >  echo "The files were rebuilt and can be added to git."
> >  echo "However, if new files were created, please copy them manually" \
> 
>