From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45746) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xgr4q-0002u4-M6 for qemu-devel@nongnu.org; Wed, 22 Oct 2014 04:15:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xgr4l-0006Aw-9o for qemu-devel@nongnu.org; Wed, 22 Oct 2014 04:15:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35195) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xgr4l-0006Ap-1r for qemu-devel@nongnu.org; Wed, 22 Oct 2014 04:15:23 -0400 Date: Wed, 22 Oct 2014 11:18:53 +0300 From: "Michael S. Tsirkin" Message-ID: <20141022081853.GA7797@redhat.com> References: <20141020190358.GA12441@redhat.com> <87vbnddb1b.fsf@blackfin.pond.sub.org> <20141021100047.GA18294@redhat.com> <87iojdy5m6.fsf@blackfin.pond.sub.org> <20141021123848.GA23765@redhat.com> <87vbndtutx.fsf@blackfin.pond.sub.org> <20141021223032.GC18051@redhat.com> <87a94oehfk.fsf@blackfin.pond.sub.org> <20141022070143.GA23513@redhat.com> <20141022101058.4b40509b@oc7435384737.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141022101058.4b40509b@oc7435384737.ibm.com> Subject: Re: [Qemu-devel] [PATCH] get_maintainer.pl: Default to --no-git-fallback List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: Peter Maydell , Markus Armbruster , QEMU Developers On Wed, Oct 22, 2014 at 10:10:58AM +0200, Thomas Huth wrote: > On Wed, 22 Oct 2014 10:01:43 +0300 > "Michael S. Tsirkin" wrote: > > > On Wed, Oct 22, 2014 at 08:39:59AM +0200, Markus Armbruster wrote: > > > "Michael S. Tsirkin" writes: > > > > > > > On Tue, Oct 21, 2014 at 03:29:14PM +0200, Markus Armbruster wrote: > > > >> "Michael S. Tsirkin" writes: > > > >> > > > >> > On Tue, Oct 21, 2014 at 02:22:41PM +0200, Markus Armbruster wrote: > > > [...] > > > >> >> My patch to get_maintainers.pl triggered a whole thread, while the > > > >> >> message I sent on MAINTAINERS coverage got just one reply so far, and > > > >> >> even that one's really just about get_maintainers.pl. Disappointing. > > > >> >> Looks like we're still looking for an easy technical fix. I doubt there > > > >> >> is one. > > > >> > > > > >> > At least for myself, that's because I'm Cc'd directly on the patch > > > >> > but not on the MAINTAINERS coverage mail. > > > >> > And that's ... because get_maintainers picks my mail from git? > > > >> > > > > >> > See how it's useful now? > > > >> > > > >> Except that's not what happened. > > > >> > > > >> $ scripts/get_maintainer.pl --git-fallback -f scripts/get_maintainer.pl > > > >> > > > >> No output. I picked you from git-log manually. > > > > > > > > Weird. > > > > It works for me: > > > > ./scripts/get_maintainer.pl -f scripts/get_maintainer.pl > > > > "Michael S. Tsirkin" (commit_signer:1/1=100%) > > > > > > > > Maybe --git-fallback is broken? > > > > > > I tried on master (i.e. without my patch, clean tree, with and without > > > --git-fallback. Just tried it again, same result. > > > > Well ... I don't know why. > > It's clearly a bug. > > Different perl version? Different git version? > > > > Can you try tracing it? > > Does it exec git? > > I've got the same behaviour as Markus (i.e. no output), and I think > this is due to get_maintainer.pl using $email_git_since = "1-year-ago" > ... since there wasn't a commit to that file in the last year, git-log > simply does not output any entry at all. > Do you have a non-upstream commit in your git tree that changes that > file? That would explain why you get some output here. > > Thomas Aha. Right. Thanks!