From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47970) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XgrF6-00036J-P1 for qemu-devel@nongnu.org; Wed, 22 Oct 2014 04:26:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XgrF2-0000yf-C3 for qemu-devel@nongnu.org; Wed, 22 Oct 2014 04:26:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54929) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XgrF1-0000yZ-Q8 for qemu-devel@nongnu.org; Wed, 22 Oct 2014 04:26:00 -0400 Date: Wed, 22 Oct 2014 11:29:32 +0300 From: "Michael S. Tsirkin" Message-ID: <20141022082932.GB7797@redhat.com> References: <1413796790-30579-1-git-send-email-armbru@redhat.com> <20141020141548.GA11062@redhat.com> <544556A1.3020405@redhat.com> <87r3y1tukp.fsf@blackfin.pond.sub.org> <20141021223129.GD18051@redhat.com> <8738agegfv.fsf@blackfin.pond.sub.org> <20141022071257.GA24952@redhat.com> <871tq0jzti.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <871tq0jzti.fsf@blackfin.pond.sub.org> Subject: Re: [Qemu-devel] [PATCH] get_maintainer.pl: Default to --no-git-fallback List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Paolo Bonzini , QEMU Developers , Peter Maydell On Wed, Oct 22, 2014 at 10:03:53AM +0200, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > On Wed, Oct 22, 2014 at 09:01:24AM +0200, Markus Armbruster wrote: > >> "Michael S. Tsirkin" writes: > >> > >> > On Tue, Oct 21, 2014 at 03:34:46PM +0200, Markus Armbruster wrote: > >> >> Paolo Bonzini writes: > >> >> > >> >> > On 10/20/2014 04:15 PM, Michael S. Tsirkin wrote: > >> >> >> What do you want to happen in this case? > >> >> >> Won't this cause even more patches to fall to the floor? > >> >> >> > >> >> >> The benefit seems marginal, the risk high. > >> >> > > >> >> > I agree with Michael. > >> >> > > >> >> > Can we detect if get_maintainer.pl is invoked as a cccmd, and in this > >> >> > case default to --no-git-fallback? If it is invoked manually, I would > >> >> > like to show the committers (I will then cherry pick the right ones). > >> >> > >> >> I don't like context-sensitive defaults. Too much magic. > >> >> > >> >> What about this: if get_maintainer.pl comes up empty, it points you to > >> >> --git-fallback. > >> > > >> > This is exactly what it's doing now :) > >> > >> Nope. This is what it's doing now: > >> > >> $ scripts/get_maintainer.pl -f util/cutils.c > >> Luiz Capitulino (commit_signer:1/2=50%) > >> Eric Blake (commit_signer:1/2=50%) > >> Alexey Kardashevskiy (commit_signer:1/2=50%) > >> Laszlo Ersek (commit_signer:1/2=50%) > >> Amit Shah (commit_signer:1/2=50%) > >> > >> A sufficiently seasoned contributor will spot the "commit_signer" tags, > >> and the output as a hint to find people to copy. In this particular > >> case, he'll recognize the hint is useless. Maybe he'll try something > >> like --git-since 2010 or --git-blame then. I'd just peruse git-log. > >> > >> A less seasoned contributor will blindly copy all five. > > > > I give up. What's the correct answer? > > I frankly don't know whom should one copy on this file. > > Fabrice? > > Fabrice would be a textbook example of a useless cc. > > I'd pick based on the patch's contents. For instance, if it fixes a > function that is used by block stuff only, try copying block > maintainers. You get the idea. It's an art, not something a dumb > script can do. > > An inexperienced contributor probably won't be able to find out whom to > copy here. Making him send out five mostly useless copies is not a > solution. Maybe disable fallback just for utils: +UTIL +M: qemu-devel@nongnu.org +S: Odd Fixes +F: util/ > Don proposed adding a catchall maintainer, and Peter refined > it to qemu-unmaintained@... This could serve as a formal cry "I have no > idea who could review this, please help me". > > [...] The list is a good idea. But I'd like a flag to avoid adding that automatically. Call it --expert or whatever. So need to write some code in get_maintainer. -- MST