From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60567)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Xgs5s-0000hX-49
	for qemu-devel@nongnu.org; Wed, 22 Oct 2014 05:20:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Xgs5m-0002Tq-Mf
	for qemu-devel@nongnu.org; Wed, 22 Oct 2014 05:20:36 -0400
Received: from mx1.redhat.com ([209.132.183.28]:10877)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Xgs5m-0002Tm-DS
	for qemu-devel@nongnu.org; Wed, 22 Oct 2014 05:20:30 -0400
Received: from int-mx13.intmail.prod.int.phx2.redhat.com
	(int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9M9KTHk011122
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Wed, 22 Oct 2014 05:20:30 -0400
Date: Wed, 22 Oct 2014 12:24:05 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20141022092405.GA9425@redhat.com>
References: <1413968902-24094-1-git-send-email-pbonzini@redhat.com>
	<1413968902-24094-3-git-send-email-pbonzini@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1413968902-24094-3-git-send-email-pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/4] get_maintainer.pl: treat all M entries
	the same
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, armbru@redhat.com

On Wed, Oct 22, 2014 at 11:08:20AM +0200, Paolo Bonzini wrote:
> Why should get_maintainer bother if someone puts his name as maintainer
> on an "Orphan" entry?  Garbage in, email out.  The results from the git
> fallback are likely to be from someone doing sweeping changes on the
> whole tree, and thus not really interesting.
> 
> Reported-by: Gerd Hoffmann <kraxel@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Looks good to me

Reviewed-by: Michael S. Tsirkin <mst@redhat.com>

I will add text that explains that the effect for current tree is
disabling fallback for Odd fixes projects.


> ---
>  scripts/get_maintainer.pl | 19 -------------------
>  1 file changed, 19 deletions(-)
> 
> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> index a3a16d8..6c5a73b 100755
> --- a/scripts/get_maintainer.pl
> +++ b/scripts/get_maintainer.pl
> @@ -505,24 +505,6 @@ if ($web) {
>  
>  exit($exit);
>  
> -sub range_is_maintained {
> -    my ($start, $end) = @_;
> -
> -    for (my $i = $start; $i < $end; $i++) {
> -	my $line = $typevalue[$i];
> -	if ($line =~ m/^(\C):\s*(.*)/) {
> -	    my $type = $1;
> -	    my $value = $2;
> -	    if ($type eq 'S') {
> -		if ($value =~ /(maintain|support)/i) {
> -		    return 1;
> -		}
> -	    }
> -	}
> -    }
> -    return 0;
> -}
> -
>  sub range_has_maintainer {
>      my ($start, $end) = @_;
>  
> @@ -602,7 +584,6 @@ sub get_maintainers {
>  				$value_pd++ if (substr($value,-1,1) ne "/");
>  				$value_pd = -1 if ($value =~ /^\.\*/);
>  				if ($value_pd >= $file_pd &&
> -				    range_is_maintained($start, $end) &&
>  				    range_has_maintainer($start, $end)) {
>  				    $exact_pattern_match_hash{$file} = 1;
>  				}
> -- 
> 1.8.3.1
>