From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42529) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XgslN-0008Fk-Oz for qemu-devel@nongnu.org; Wed, 22 Oct 2014 06:03:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XgslI-0000vE-AF for qemu-devel@nongnu.org; Wed, 22 Oct 2014 06:03:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54126) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XgslI-0000v6-2w for qemu-devel@nongnu.org; Wed, 22 Oct 2014 06:03:24 -0400 Date: Wed, 22 Oct 2014 11:03:18 +0100 From: Stefan Hajnoczi Message-ID: <20141022100318.GC8798@stefanha-thinkpad.redhat.com> References: <20141020102559.GA29278@stefanha-thinkpad.redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="GZVR6ND4mMseVXL/" Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] Patch checking bot List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: John Snow , Fam Zheng , QEMU Developers --GZVR6ND4mMseVXL/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 20, 2014 at 03:08:35PM +0100, Peter Maydell wrote: > On 20 October 2014 11:25, Stefan Hajnoczi wrote: > > Hi, > > At KVM Forum 2014 we discussed a patch checking bot that automates patch > > format checking and smoke testing: > > > > 1. Did the patch submitter include Signed-off-by? > > 2. Does checkpatch.pl pass? > > 3. Does the patch apply to qemu.git/master? > > 4. Does each patch compile? > > 5. Does the series pass make check and qemu-iotests? > > > > Here are some thoughts on the patch checker: > > > > If a patch series passes successfully, no email is sent. If a patch > > series fails, an email with the errors is sent as a reply to the patch > > series email thread. The patch submitter can then respond in case there > > are false positive (e.g. from checkpatch.pl) - the bot doesn't care > > about replies but it tells the human reviewers and maintainers what the > > patch submitter intends to do. >=20 > Probably also worth having a feature where the cover > letter or patch can have a "patchchecker: no" line in > it to tell the bot to ignore something, so people can > avoid it sending lots of mail for patch series they > know don't apply to mainline (eg ones which depend on > a previous series). The bot would send 1 email reply with a report of all errors. That doesn't seem too noisy. That said, a header line to ignore the series is easy to implement so we might as well. Stefan --GZVR6ND4mMseVXL/ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUR4DmAAoJEJykq7OBq3PIIV0H/j9nWrGSmrilwSLF2JQE6v04 cJQj5wfAIXnTfodSP3JBbCA2ttKMSfyLVmlVk+TsSrvuCt1Ey7y3gkbH/j+PNOpr kIutdmU5pvJEcebWGbJB1Uw5u2tQKj4qSj7ouZaOUIc2znnWixd2+65X4IqSgNHq vrtYQQs8vVYqN9aNP8HWzfggEro0dqke3UDHbTXpgHc8IEBRFBrvNcpwpWpqX0mI cxnZ0q0LgQCIbKjBarM+rQNbQyjy2qHTV5ctmpmUZwVQJqfQYKErdhkklA8Gvd2d INME9IQj1Fa8Z85QH/g2o84+e17RPCHs42wzaNVokuMiOv1omDOZfrFSajzYAgY= =GbR5 -----END PGP SIGNATURE----- --GZVR6ND4mMseVXL/--