Re: [Qemu-devel] Patch checking bot

[Stefan Hajnoczi <stefanha@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1106 bytes --]

On Tue, Oct 21, 2014 at 04:19:52PM +0800, Fam Zheng wrote:
> On Mon, Oct 20, 2014 at 6:25 PM, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> > Use docker or lxc to run a container for builds.  The root file system
> > should be fresh for each build so previous builds cannot affect later
> > ones.  The container cannot have external networking connectivity (for
> > security).
> 
> A small question: if the container doesn't have network connectivity,
> where does the bot's checking scripts read the patch mail from?

The bot runs outside the container.  It uses 'patches fetch' to grab the
latest patches database every 15 minutes or so.

When a new patch series is detected, it creates a new container and
places an mbox that git-apply(1) can process inside the container.

The rest happens inside the container:

  cd qemu
  scripts/checkpatch.pl </tmp/patches.mbox
  git apply </tmp/patches.mbox
  ./configure ... && make
  make check check-block

Once the checker completes the bot can update the status web page and
send out an error report email, if necessary.

Stefan

[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]