From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43478) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xgspz-0006zx-JV for qemu-devel@nongnu.org; Wed, 22 Oct 2014 06:08:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xgspu-0002Qn-6A for qemu-devel@nongnu.org; Wed, 22 Oct 2014 06:08:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44937) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xgspt-0002Q2-Uu for qemu-devel@nongnu.org; Wed, 22 Oct 2014 06:08:10 -0400 Date: Wed, 22 Oct 2014 11:08:06 +0100 From: Stefan Hajnoczi Message-ID: <20141022100806.GD8798@stefanha-thinkpad.redhat.com> References: <20141020102559.GA29278@stefanha-thinkpad.redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="F8dlzb82+Fcn6AgP" Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] Patch checking bot List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: John Snow , Fam Zheng , "qemu-devel@nongnu.org" --F8dlzb82+Fcn6AgP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 21, 2014 at 04:19:52PM +0800, Fam Zheng wrote: > On Mon, Oct 20, 2014 at 6:25 PM, Stefan Hajnoczi wr= ote: > > Use docker or lxc to run a container for builds. The root file system > > should be fresh for each build so previous builds cannot affect later > > ones. The container cannot have external networking connectivity (for > > security). >=20 > A small question: if the container doesn't have network connectivity, > where does the bot's checking scripts read the patch mail from? The bot runs outside the container. It uses 'patches fetch' to grab the latest patches database every 15 minutes or so. When a new patch series is detected, it creates a new container and places an mbox that git-apply(1) can process inside the container. The rest happens inside the container: cd qemu scripts/checkpatch.pl