Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

[Michael Roth <mdroth@linux.vnet.ibm.com>]

Quoting Markus Armbruster (2014-10-22 06:45:44)
> Paolo Bonzini <pbonzini@redhat.com> writes:
> 
> >> Down to 491 our of 1841 (27%).  Progress, but not quite enough.
> >
> > I think a better analysis would be on patches, not files.  Which is
> > really hard to do, of course.
> >
> > But as a rule of thumb, tests/ and include/ patches should also touch
> > files outside those directories.  Not many people, unfortunately, write
> > tests out of a whim.  So I wouldn't care much about those.
> 
> Focusing on non-test, non-header source code for now seems sensible.
> 
> > Some low-hanging fruit:
> >
> >> libcacard/Makefile
> >> libcacard/cac.c
> >> libcacard/cac.h
> >> libcacard/card_7816.c
> >> libcacard/card_7816.h
> >> libcacard/card_7816t.h
> >> libcacard/event.c
> >> libcacard/eventt.h
> >> libcacard/libcacard.pc.in
> >> libcacard/libcacard.syms
> >> libcacard/link_test.c
> >> libcacard/vcard.c
> >> libcacard/vcard.h
> >> libcacard/vcard_emul.h
> >> libcacard/vcard_emul_nss.c
> >> libcacard/vcard_emul_type.c
> >> libcacard/vcard_emul_type.h
> >> libcacard/vcardt.c
> >> libcacard/vcardt.h
> >> libcacard/vcardt_internal.h
> >> libcacard/vevent.h
> >> libcacard/vreader.c
> >> libcacard/vreader.h
> >> libcacard/vreadert.h
> >> libcacard/vscard_common.h
> >> libcacard/vscclient.c
> >
> > Alon?
> >
> >> libdecnumber/decContext.c
> >> libdecnumber/decNumber.c
> >> libdecnumber/dpd/decimal128.c
> >> libdecnumber/dpd/decimal128Local.h
> >> libdecnumber/dpd/decimal32.c
> >> libdecnumber/dpd/decimal64.c
> >
> > Part of TCG PPC.
> 
> Give me a name :)
> 
> >> qga/Makefile.objs
> >> qga/channel-posix.c
> >> qga/channel-win32.c
> >> qga/channel.h
> >> qga/commands-posix.c
> >> qga/commands-win32.c
> >> qga/commands.c
> >> qga/guest-agent-command-state.c
> >> qga/guest-agent-core.h
> >> qga/main.c
> >> qga/qapi-schema.json
> >> qga/service-win32.c
> >> qga/service-win32.h
> >> qga/vss-win32.c
> >> qga/vss-win32.h
> >> qga/vss-win32/Makefile.objs
> >> qga/vss-win32/install.cpp
> >> qga/vss-win32/provider.cpp
> >> qga/vss-win32/qga-vss.def
> >> qga/vss-win32/qga-vss.idl
> >> qga/vss-win32/qga-vss.tlb
> >> qga/vss-win32/requester.cpp
> >> qga/vss-win32/requester.h
> >> qga/vss-win32/vss-common.h
> >
> > Mike Roth?
> 
> Cc'ed.

Of course, just never thought to add it. Just sent a patch for MAINTAINERS.

> 
> >> qobject/Makefile.objs
> >> qobject/json-lexer.c
> >> qobject/json-parser.c
> >> qobject/json-streamer.c
> >> qobject/qbool.c
> >> qobject/qdict.c
> >> qobject/qerror.c
> >> qobject/qfloat.c
> >> qobject/qint.c
> >> qobject/qjson.c
> >> qobject/qlist.c
> >> qobject/qstring.c
> >
> > Part of QMP.
> 
> Cc'ing Luiz.