From: Kevin Wolf <kwolf@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: qemu-devel@nongnu.org, "Stefan Hajnoczi" <stefanha@redhat.com>,
"Benoît Canet" <benoit.canet@nodalink.com>
Subject: Re: [Qemu-devel] [PATCH v2 0/3] qcow2: Drop REFCOUNT_SHIFT
Date: Wed, 22 Oct 2014 14:14:20 +0200 [thread overview]
Message-ID: <20141022121420.GH3188@noname.str.redhat.com> (raw)
In-Reply-To: <1409696709-27623-1-git-send-email-mreitz@redhat.com>
Am 03.09.2014 um 00:25 hat Max Reitz geschrieben:
> In preparation for qemu maybe actually supporting variable refcount
> widths in the far future, drop the hardcoded REFCOUNT_SHIFT and instead
> use the value as given by the image.
>
> Also, the qcow2 documentation gave the width of a refcount block entry
> as sizeof(uint16_t), which is wrong for any refcount order other than 4.
> Fix that.
>
> This is a follow-up to my "[PATCH v5 00/11] qcow2: Fix image repairing"
> series and therefore depends on it.
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
next prev parent reply other threads:[~2014-10-22 12:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 22:25 [Qemu-devel] [PATCH v2 0/3] qcow2: Drop REFCOUNT_SHIFT Max Reitz
2014-09-02 22:25 ` [Qemu-devel] [PATCH v2 1/3] " Max Reitz
2014-09-02 22:25 ` [Qemu-devel] [PATCH v2 2/3] docs/qcow2: Correct refcount_block_entries Max Reitz
2014-09-02 22:28 ` Eric Blake
2014-09-03 13:51 ` Stefan Hajnoczi
2014-09-02 22:25 ` [Qemu-devel] [PATCH v2 3/3] docs/qcow2: Limit refcount_order to [0, 6] Max Reitz
2014-09-02 22:30 ` Eric Blake
2014-09-03 13:51 ` Stefan Hajnoczi
2014-10-22 12:14 ` Kevin Wolf [this message]
2014-10-22 13:18 ` [Qemu-devel] [PATCH v2 0/3] qcow2: Drop REFCOUNT_SHIFT Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141022121420.GH3188@noname.str.redhat.com \
--to=kwolf@redhat.com \
--cc=benoit.canet@nodalink.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).