From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43481) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XguoB-0006eU-4f for qemu-devel@nongnu.org; Wed, 22 Oct 2014 08:14:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xguo5-0007DS-0C for qemu-devel@nongnu.org; Wed, 22 Oct 2014 08:14:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45351) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xguo4-0007DJ-Q1 for qemu-devel@nongnu.org; Wed, 22 Oct 2014 08:14:24 -0400 Date: Wed, 22 Oct 2014 14:14:20 +0200 From: Kevin Wolf Message-ID: <20141022121420.GH3188@noname.str.redhat.com> References: <1409696709-27623-1-git-send-email-mreitz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1409696709-27623-1-git-send-email-mreitz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 0/3] qcow2: Drop REFCOUNT_SHIFT List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: qemu-devel@nongnu.org, Stefan Hajnoczi , =?iso-8859-1?Q?Beno=EEt?= Canet Am 03.09.2014 um 00:25 hat Max Reitz geschrieben: > In preparation for qemu maybe actually supporting variable refcount > widths in the far future, drop the hardcoded REFCOUNT_SHIFT and instead > use the value as given by the image. > > Also, the qcow2 documentation gave the width of a refcount block entry > as sizeof(uint16_t), which is wrong for any refcount order other than 4. > Fix that. > > This is a follow-up to my "[PATCH v5 00/11] qcow2: Fix image repairing" > series and therefore depends on it. Reviewed-by: Kevin Wolf