From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33500) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xgvo5-0005U6-HE for qemu-devel@nongnu.org; Wed, 22 Oct 2014 09:18:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xgvnz-0005TR-CM for qemu-devel@nongnu.org; Wed, 22 Oct 2014 09:18:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51345) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xgvnz-0005TN-55 for qemu-devel@nongnu.org; Wed, 22 Oct 2014 09:18:23 -0400 Date: Wed, 22 Oct 2014 15:18:18 +0200 From: Kevin Wolf Message-ID: <20141022131818.GJ3188@noname.str.redhat.com> References: <1413979783-1549-1-git-send-email-mreitz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1413979783-1549-1-git-send-email-mreitz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v8 00/17] qcow2: Fix image repairing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: qemu-devel@nongnu.org, Stefan Hajnoczi , =?iso-8859-1?Q?Beno=EEt?= Canet Am 22.10.2014 um 14:09 hat Max Reitz geschrieben: > As can be seen in the final patch of this series, there are certain > cases where the current repair implementation of qcow2 actually damages > the image further because it allocates new clusters for the refcount > structure which overlap with existing but according to the on-disk > refcounts (which are assumed to be wrong to begin with) unallocated > clusters. > > This series fixes this by completely recreating the refcount structure > based on the in-memory information calculated during the check operation > if the possibility of damaging the image while repairing the refcount > structures in-place exists. Thanks, applied to the block branch. Kevin