From: Kevin Wolf <kwolf@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v13 06/14] iotests: Omit length/offset test in 040 and 041
Date: Thu, 23 Oct 2014 12:06:32 +0200 [thread overview]
Message-ID: <20141023100632.GI3522@noname.redhat.com> (raw)
In-Reply-To: <1413982283-10186-7-git-send-email-mreitz@redhat.com>
Am 22.10.2014 um 14:51 hat Max Reitz geschrieben:
> As of a follow-up patch to this one, the length of a mirror block job
> will no longer directly depend on the size of the block device;
> therefore, drop these checks from this test. Instead, just check whether
> the final offset equals the block job length.
>
> As 041 uses the wait_until_completed function from iotests.py, the same
> applies there as well which in turn affects tests 030, 055 and 056. On
> the other hand, a block job's length does not have to be related to the
> length of the image file in the first place, so that check was
> questionable anyway.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
Possibly a result of rebasing over a long time, but 041 still has some
checks of len left after this patch.
Kevin
next prev parent reply other threads:[~2014-10-23 10:06 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-22 12:51 [Qemu-devel] [PATCH v13 00/14] qemu-img: Implement commit like QMP Max Reitz
2014-10-22 12:51 ` [Qemu-devel] [PATCH v13 01/14] qcow2: Allow "full" discard Max Reitz
2014-10-22 12:51 ` [Qemu-devel] [PATCH v13 02/14] qcow2: Implement bdrv_make_empty() Max Reitz
2014-10-22 12:51 ` [Qemu-devel] [PATCH v13 03/14] qcow2: Optimize bdrv_make_empty() Max Reitz
2014-10-22 16:04 ` Eric Blake
2014-10-22 18:35 ` Kevin Wolf
2014-10-23 7:46 ` Max Reitz
2014-10-23 8:29 ` Kevin Wolf
2014-10-23 8:36 ` Max Reitz
2014-10-23 8:41 ` Kevin Wolf
2014-10-23 9:11 ` Max Reitz
2014-10-23 9:42 ` Kevin Wolf
2014-10-23 9:44 ` Max Reitz
2014-10-22 12:51 ` [Qemu-devel] [PATCH v13 04/14] blockjob: Introduce block_job_complete_sync() Max Reitz
2014-10-22 12:51 ` [Qemu-devel] [PATCH v13 05/14] blockjob: Add "ready" field Max Reitz
2014-10-23 10:01 ` Kevin Wolf
2014-10-22 12:51 ` [Qemu-devel] [PATCH v13 06/14] iotests: Omit length/offset test in 040 and 041 Max Reitz
2014-10-23 10:06 ` Kevin Wolf [this message]
2014-10-23 10:07 ` Max Reitz
2014-10-22 12:51 ` [Qemu-devel] [PATCH v13 07/14] block/mirror: Improve progress report Max Reitz
2014-10-23 10:52 ` Kevin Wolf
2014-10-23 11:09 ` Max Reitz
2014-10-23 12:03 ` Kevin Wolf
2014-10-23 13:10 ` Eric Blake
2014-10-22 12:51 ` [Qemu-devel] [PATCH v13 08/14] qemu-img: Implement commit like QMP Max Reitz
2014-10-22 16:22 ` Eric Blake
2014-10-23 11:59 ` Kevin Wolf
2014-10-23 12:35 ` Max Reitz
2014-10-23 12:40 ` Kevin Wolf
2014-10-23 12:44 ` Max Reitz
2014-10-22 12:51 ` [Qemu-devel] [PATCH v13 09/14] qemu-img: Empty image after commit Max Reitz
2014-10-23 12:55 ` Kevin Wolf
2014-10-22 12:51 ` [Qemu-devel] [PATCH v13 10/14] qemu-img: Enable progress output for commit Max Reitz
2014-10-23 13:00 ` Kevin Wolf
2014-10-22 12:51 ` [Qemu-devel] [PATCH v13 11/14] qemu-img: Specify backing file " Max Reitz
2014-10-23 13:05 ` Kevin Wolf
2014-10-22 12:51 ` [Qemu-devel] [PATCH v13 12/14] iotests: Add _filter_qemu_img_map Max Reitz
2014-10-23 13:08 ` Kevin Wolf
2014-10-22 12:51 ` [Qemu-devel] [PATCH v13 13/14] iotests: Add test for backing-chain commits Max Reitz
2014-10-23 13:24 ` Kevin Wolf
2014-10-22 12:51 ` [Qemu-devel] [PATCH v13 14/14] iotests: Add test for qcow2's bdrv_make_empty Max Reitz
2014-10-22 17:05 ` Eric Blake
2014-10-23 13:30 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141023100632.GI3522@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).