qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrange" <berrange@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] gtk: avoid gd_widget_reparent with gtk 3.14+
Date: Thu, 23 Oct 2014 17:31:46 +0100	[thread overview]
Message-ID: <20141023163146.GB26984@redhat.com> (raw)
In-Reply-To: <54492C2D.5000407@redhat.com>

On Thu, Oct 23, 2014 at 06:26:21PM +0200, Paolo Bonzini wrote:
> 
> 
> On 10/23/2014 05:25 PM, Gerd Hoffmann wrote:
> > gtk_widget_reparent is depricated in gtk 3.14.  Unfortunaly the
> > gtk_widget_{ref,unref} functions needed to to the same manually
> > without having the widget destroyed while it has no parent are
> > pretty new.  So there is no way around #ifdef'ing the code,
> > otherwise it breaks with older gtk versions,
> 
> I cannot find gtk_widget_ref/unref in
> https://developer.gnome.org/gtk3/stable/GtkWidget.html.  How do they
> differ from g_object_ref(G_OBJECT(widget))?

Indeed, it doesn't exist in GTK3 so I'm not sure how this built
successfully on GTK3 !  It was deprecated in favour of g_object_ref
from 2.12 and deleted in 3.x series.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

      reply	other threads:[~2014-10-23 16:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-23 15:25 [Qemu-devel] [PATCH 1/2] gtk: drop gtk_widget_set_double_buffered call Gerd Hoffmann
2014-10-23 15:25 ` [Qemu-devel] [PATCH 2/2] gtk: avoid gd_widget_reparent with gtk 3.14+ Gerd Hoffmann
2014-10-23 16:26   ` Paolo Bonzini
2014-10-23 16:31     ` Daniel P. Berrange [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141023163146.GB26984@redhat.com \
    --to=berrange@redhat.com \
    --cc=aliguori@amazon.com \
    --cc=dgilbert@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).