From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53013) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XhLIu-00086L-9u for qemu-devel@nongnu.org; Thu, 23 Oct 2014 12:32:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XhLIq-0006T2-Jp for qemu-devel@nongnu.org; Thu, 23 Oct 2014 12:32:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32315) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XhLIq-0006Ss-Bq for qemu-devel@nongnu.org; Thu, 23 Oct 2014 12:31:56 -0400 Date: Thu, 23 Oct 2014 17:31:46 +0100 From: "Daniel P. Berrange" Message-ID: <20141023163146.GB26984@redhat.com> References: <1414077919-29271-1-git-send-email-kraxel@redhat.com> <1414077919-29271-2-git-send-email-kraxel@redhat.com> <54492C2D.5000407@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <54492C2D.5000407@redhat.com> Subject: Re: [Qemu-devel] [PATCH 2/2] gtk: avoid gd_widget_reparent with gtk 3.14+ Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, Anthony Liguori , "Dr. David Alan Gilbert" On Thu, Oct 23, 2014 at 06:26:21PM +0200, Paolo Bonzini wrote: > > > On 10/23/2014 05:25 PM, Gerd Hoffmann wrote: > > gtk_widget_reparent is depricated in gtk 3.14. Unfortunaly the > > gtk_widget_{ref,unref} functions needed to to the same manually > > without having the widget destroyed while it has no parent are > > pretty new. So there is no way around #ifdef'ing the code, > > otherwise it breaks with older gtk versions, > > I cannot find gtk_widget_ref/unref in > https://developer.gnome.org/gtk3/stable/GtkWidget.html. How do they > differ from g_object_ref(G_OBJECT(widget))? Indeed, it doesn't exist in GTK3 so I'm not sure how this built successfully on GTK3 ! It was deprecated in favour of g_object_ref from 2.12 and deleted in 3.x series. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|