From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59901)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <chao.p.peng@linux.intel.com>) id 1XiZjE-0007Jh-7N
	for qemu-devel@nongnu.org; Sun, 26 Oct 2014 22:08:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <chao.p.peng@linux.intel.com>) id 1XiZj9-000225-5J
	for qemu-devel@nongnu.org; Sun, 26 Oct 2014 22:08:16 -0400
Received: from mga11.intel.com ([192.55.52.93]:55049)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <chao.p.peng@linux.intel.com>) id 1XiZj9-00020J-0y
	for qemu-devel@nongnu.org; Sun, 26 Oct 2014 22:08:11 -0400
Date: Mon, 27 Oct 2014 10:07:52 +0800
From: Chao Peng <chao.p.peng@linux.intel.com>
Message-ID: <20141027020752.GC3135@pengc-linux.bj.intel.com>
References: <1414033363-31032-1-git-send-email-chao.p.peng@linux.intel.com>
	<20141024160144.GB25413@thinpad.lan.raisama.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20141024160144.GB25413@thinpad.lan.raisama.net>
Subject: Re: [Qemu-devel] [PATCH] target-i386: add Intel AVX-512 support
Reply-To: Chao Peng <chao.p.peng@linux.intel.com>
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>, qemu-devel@nongnu.org, Vadim Rozenfeld <vrozenfe@redhat.com>, Laszlo Ersek <lersek@redhat.com>, Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>

On Fri, Oct 24, 2014 at 02:01:44PM -0200, Eduardo Habkost wrote:
> On Thu, Oct 23, 2014 at 11:02:43AM +0800, Chao Peng wrote:
> > Add AVX512 feature bits, register definition and corresponding
> > xsave/vmstate support.
> > 
> > Signed-off-by: Chao Peng <chao.p.peng@linux.intel.com>
> > ---
> [...]

I agree to the cleanup scheme paolo suggested.
And thanks Eduardo for going thru the spec and double checking for
this.

> > @@ -745,6 +829,9 @@ VMStateDescription vmstate_x86_cpu = {
> >          }, {
> >              .vmsd = &vmstate_msr_hyperv_time,
> >              .needed = hyperv_time_enable_needed,
> > +	}, {
> > +            .vmsd = &vmstate_avx512,
> > +            .needed = avx512_needed,
> >          } , {
> >              /* empty */
> 
> The tab character above needs to be replaced by spaces, but the rest
> looks good and matches the Intel docs.
> 
> Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>

If this is the only issue, paolo, could you help on this when you
commit? Thank you.

Chao