From: Luiz Capitulino <lcapitulino@redhat.com>
To: zhanghailiang <zhang.zhanghailiang@huawei.com>
Cc: luonengjun@huawei.com, qemu-devel@nongnu.org,
peter.huangpeng@huawei.com, Gonglei <arei.gonglei@huawei.com>,
imammedo@redhat.com, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH v6] numa: make 'info numa' take into account hotplugged memory
Date: Mon, 27 Oct 2014 08:46:59 -0400 [thread overview]
Message-ID: <20141027084659.13cbdf8a@redhat.com> (raw)
In-Reply-To: <544E12FB.6070904@huawei.com>
On Mon, 27 Oct 2014 17:40:11 +0800
zhanghailiang <zhang.zhanghailiang@huawei.com> wrote:
> Hi Luiz,
>
> Can you apply this to your qmp branch?
> It has been reviewd;)
I can, but I don't have bandwidth for another pull request for v2.2 unless
it's a fix for a blocker. This means you have two options, wait for v2.3
or find another tree to merge this.
>
> Thanks,
> zhanghailiang
>
> On 2014/10/23 8:32, zhanghailiang wrote:
> > Hi,
> >
> > Ping...
> > This patch has been reviewed, please pick up, Thanks.
> >
> > Best Regargs,
> > zhanghailiang
> >
> > On 2014/10/17 17:02, Gonglei wrote:
> >> On 2014/10/17 16:50, zhanghailiang wrote:
> >>
> >>> When do memory hotplug, if there is numa node, we should add
> >>> the memory size to the corresponding node memory size.
> >>>
> >>> For now, it mainly affects the result of hmp command "info numa".
> >>>
> >>> Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> >>> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
> >>> ---
> >>> v6:
> >>> - remove unnecessary 'di' variable (GongLei)
> >>> v5:
> >>> - reword the subject (Igor Mammedov)
> >>> - turn query_numa_node_mem to void (Igor Mammedov)
> >>> v4:
> >>> - s/pc_dimm_stat_node_mem/numa_stat_memory_devices/ (Igor Mammedov)
> >>> - rewrite numa_stat_memory_devices and this will also fix compile error for
> >>> targets that don't support memory hotplug
> >>> v3:
> >>> - cold-plugged memory should not be excluded (Igor Mammedov)
> >>> v2:
> >>> - Don't modify the numa_info.node_mem directly when treating hotplug memory,
> >>> fix the "info numa" instead (Igor Mammedov)
> >>>
> >>> Thanks for review!;)
> >>> ---
> >>>
> >>> include/sysemu/sysemu.h | 1 +
> >>> monitor.c | 6 +++++-
> >>> numa.c | 38 ++++++++++++++++++++++++++++++++++++++
> >>> 3 files changed, 44 insertions(+), 1 deletion(-)
> >>>
> >>
> >> Reviewed-by: Gonglei <arei.gonglei@huawei.com>
> >>
> >> Best regards,
> >> -Gonglei
> >>
> >>
> >> .
> >>
> >
> >
> >
> >
> >
>
>
next prev parent reply other threads:[~2014-10-27 12:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-17 8:50 [Qemu-devel] [PATCH v6] numa: make 'info numa' take into account hotplugged memory zhanghailiang
2014-10-17 9:02 ` Gonglei
2014-10-23 0:32 ` zhanghailiang
2014-10-27 9:40 ` zhanghailiang
2014-10-27 12:46 ` Luiz Capitulino [this message]
2014-10-28 0:38 ` zhanghailiang
2014-10-30 8:22 ` zhanghailiang
2014-11-02 7:03 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2014-11-03 7:56 ` Markus Armbruster
2014-11-03 8:06 ` [Qemu-devel] " Michael Tokarev
2014-11-03 14:39 ` Markus Armbruster
2014-11-03 11:54 ` [Qemu-devel] [Qemu-trivial] " zhanghailiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141027084659.13cbdf8a@redhat.com \
--to=lcapitulino@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=imammedo@redhat.com \
--cc=luonengjun@huawei.com \
--cc=pbonzini@redhat.com \
--cc=peter.huangpeng@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).