From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48911) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xijha-0006gh-LN for qemu-devel@nongnu.org; Mon, 27 Oct 2014 08:47:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XijhV-0006lZ-Rd for qemu-devel@nongnu.org; Mon, 27 Oct 2014 08:47:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55762) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XijhV-0006jL-Kw for qemu-devel@nongnu.org; Mon, 27 Oct 2014 08:47:09 -0400 Date: Mon, 27 Oct 2014 08:46:59 -0400 From: Luiz Capitulino Message-ID: <20141027084659.13cbdf8a@redhat.com> In-Reply-To: <544E12FB.6070904@huawei.com> References: <1413535838-11000-1-git-send-email-zhang.zhanghailiang@huawei.com> <5440DB35.9020507@huawei.com> <54484C88.3070305@huawei.com> <544E12FB.6070904@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v6] numa: make 'info numa' take into account hotplugged memory List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: zhanghailiang Cc: luonengjun@huawei.com, qemu-devel@nongnu.org, peter.huangpeng@huawei.com, Gonglei , imammedo@redhat.com, pbonzini@redhat.com On Mon, 27 Oct 2014 17:40:11 +0800 zhanghailiang wrote: > Hi Luiz, > > Can you apply this to your qmp branch? > It has been reviewd;) I can, but I don't have bandwidth for another pull request for v2.2 unless it's a fix for a blocker. This means you have two options, wait for v2.3 or find another tree to merge this. > > Thanks, > zhanghailiang > > On 2014/10/23 8:32, zhanghailiang wrote: > > Hi, > > > > Ping... > > This patch has been reviewed, please pick up, Thanks. > > > > Best Regargs, > > zhanghailiang > > > > On 2014/10/17 17:02, Gonglei wrote: > >> On 2014/10/17 16:50, zhanghailiang wrote: > >> > >>> When do memory hotplug, if there is numa node, we should add > >>> the memory size to the corresponding node memory size. > >>> > >>> For now, it mainly affects the result of hmp command "info numa". > >>> > >>> Reviewed-by: Igor Mammedov > >>> Signed-off-by: zhanghailiang > >>> --- > >>> v6: > >>> - remove unnecessary 'di' variable (GongLei) > >>> v5: > >>> - reword the subject (Igor Mammedov) > >>> - turn query_numa_node_mem to void (Igor Mammedov) > >>> v4: > >>> - s/pc_dimm_stat_node_mem/numa_stat_memory_devices/ (Igor Mammedov) > >>> - rewrite numa_stat_memory_devices and this will also fix compile error for > >>> targets that don't support memory hotplug > >>> v3: > >>> - cold-plugged memory should not be excluded (Igor Mammedov) > >>> v2: > >>> - Don't modify the numa_info.node_mem directly when treating hotplug memory, > >>> fix the "info numa" instead (Igor Mammedov) > >>> > >>> Thanks for review!;) > >>> --- > >>> > >>> include/sysemu/sysemu.h | 1 + > >>> monitor.c | 6 +++++- > >>> numa.c | 38 ++++++++++++++++++++++++++++++++++++++ > >>> 3 files changed, 44 insertions(+), 1 deletion(-) > >>> > >> > >> Reviewed-by: Gonglei > >> > >> Best regards, > >> -Gonglei > >> > >> > >> . > >> > > > > > > > > > > > >