From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47362) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xijc3-0002g8-11 for qemu-devel@nongnu.org; Mon, 27 Oct 2014 08:41:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xijbx-0004ag-U8 for qemu-devel@nongnu.org; Mon, 27 Oct 2014 08:41:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50879) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xijbx-0004aF-NF for qemu-devel@nongnu.org; Mon, 27 Oct 2014 08:41:25 -0400 Date: Mon, 27 Oct 2014 12:41:15 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20141027124114.GE5021@work-vm> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] Postcopy failures List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gary Hook Cc: "qemu-devel@nongnu.org" * Gary Hook (gary.hook@nimboxx.com) wrote: > I see this went by: > > Il 07/10/2014 12:29, Dr. David Alan Gilbert ha scritto: > > You mean something like this (untested) ? > > > > if (mis->postcopy_ram_state != POSTCOPY_RAM_INCOMING_NONE) { > > if (mis->postcopy_ram_state == POSTCOPY_RAM_INCOMING_ADVISE) { > > /* > > * Where a migration had postcopy enabled (and thus went to advise) > > * but managed to complete within the precopy period > > */ > > postcopy_ram_incoming_cleanup(mis); > > } else if (ret >= 0) { > > /* > > * Postcopy was started, cleanup should happen at the end of the > > * postcopy thread. > > */ > > DPRINTF("process_incoming_migration_co: exiting main branch"); > > return; > > } > > } > > And I wonder if this will solve the problem of a peer-to-peer migration, using non-shared storage, failing because it appears to take a bit too lon? I see in other threads Dr. Gilbert is making changes related to post copy and I am very interested in getting resolution to what appears to be a timeout problem. > > Any comments would be appreciated by this newbie to Qemu. It should be possible to postcopy block storage as well, if that's the question (it might take some work to make sure that they play nicely together; e.g. wanting to making the page transfer higher priority than block transfer). However, I thought there were other ways to do block storage migration (using blockcopy I think? but I'm not a block guy). Dave -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK