From: Amit Shah <amit.shah@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>
Cc: qemu-devel@nongnu.org, kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH 2/2] spice-char: notify the server when chardev is writable
Date: Mon, 27 Oct 2014 18:13:11 +0530 [thread overview]
Message-ID: <20141027124311.GA1222@grmbl.mre> (raw)
In-Reply-To: <1414141254-31960-2-git-send-email-marcandre.lureau@gmail.com>
Hi,
On (Fri) 24 Oct 2014 [11:00:54], Marc-André Lureau wrote:
> The spice server is polling on write, unless
> SPICE_CHAR_DEVICE_NOTIFY_WRITABLE flag is set. In this case, qemu must
> call spice_server_char_device_wakeup() when the frontend is writable.
Great, so there's no other change required to actually use the
functionality in my patch? Does my patch fit your need fine, or do
you need to tweak the notification somehow?
It would be great to get your reviewed-by to my patch in case
everything's fine.
Peter has asked me to update the comments on my patch; I'll fix that
up right away since this showed up.
Thanks!
Amit
next prev parent reply other threads:[~2014-10-27 12:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-24 9:00 [Qemu-devel] [PATCH 1/2] virtio-console: notify chardev when writable Marc-André Lureau
2014-10-24 9:00 ` [Qemu-devel] [PATCH 2/2] spice-char: notify the server when chardev is writable Marc-André Lureau
2014-10-27 8:08 ` Gerd Hoffmann
2014-10-27 11:45 ` Marc-André Lureau
2014-10-27 11:57 ` Gerd Hoffmann
2015-05-04 9:31 ` Amit Shah
2015-05-05 9:45 ` Gerd Hoffmann
2014-10-27 12:43 ` Amit Shah [this message]
2014-10-27 16:32 ` Marc-André Lureau
2014-10-28 14:51 ` Amit Shah
-- strict thread matches above, loose matches on Subject: below --
2015-05-05 14:58 [Qemu-devel] [PATCH 1/2] virtio-console: notify chardev when writable Marc-André Lureau
2015-05-05 14:58 ` [Qemu-devel] [PATCH 2/2] spice-char: notify the server when chardev is writable Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141027124311.GA1222@grmbl.mre \
--to=amit.shah@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).