From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47853) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xije7-0003po-HM for qemu-devel@nongnu.org; Mon, 27 Oct 2014 08:43:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xije1-0005RS-Cr for qemu-devel@nongnu.org; Mon, 27 Oct 2014 08:43:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58215) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xije1-0005RG-4i for qemu-devel@nongnu.org; Mon, 27 Oct 2014 08:43:33 -0400 Date: Mon, 27 Oct 2014 18:13:11 +0530 From: Amit Shah Message-ID: <20141027124311.GA1222@grmbl.mre> References: <1414141254-31960-1-git-send-email-marcandre.lureau@gmail.com> <1414141254-31960-2-git-send-email-marcandre.lureau@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1414141254-31960-2-git-send-email-marcandre.lureau@gmail.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/2] spice-char: notify the server when chardev is writable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?iso-8859-1?Q?Marc-Andr=E9?= Lureau Cc: qemu-devel@nongnu.org, kraxel@redhat.com Hi, On (Fri) 24 Oct 2014 [11:00:54], Marc-Andr=E9 Lureau wrote: > The spice server is polling on write, unless > SPICE_CHAR_DEVICE_NOTIFY_WRITABLE flag is set. In this case, qemu must > call spice_server_char_device_wakeup() when the frontend is writable. Great, so there's no other change required to actually use the functionality in my patch? Does my patch fit your need fine, or do you need to tweak the notification somehow? It would be great to get your reviewed-by to my patch in case everything's fine. Peter has asked me to update the comments on my patch; I'll fix that up right away since this showed up. Thanks! Amit