From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55386) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XinzI-0001JT-I0 for qemu-devel@nongnu.org; Mon, 27 Oct 2014 13:21:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XinzA-0005gb-UV for qemu-devel@nongnu.org; Mon, 27 Oct 2014 13:21:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34523) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XinzA-0005gX-Mu for qemu-devel@nongnu.org; Mon, 27 Oct 2014 13:21:40 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9RHLdc7019771 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 27 Oct 2014 13:21:39 -0400 Date: Mon, 27 Oct 2014 19:21:34 +0200 From: "Michael S. Tsirkin" Message-ID: <20141027172134.GA18368@redhat.com> References: <1414428082-7341-1-git-send-email-marcel.a@redhat.com> <1414428082-7341-3-git-send-email-marcel.a@redhat.com> <544E7C83.4070301@redhat.com> <1414430138.29756.61.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1414430138.29756.61.camel@localhost.localdomain> Subject: Re: [Qemu-devel] [PATCH v3 2/2] hw/pci: fixed hotplug crash when using rombar=0 with devices having romfile List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum Cc: qemu-devel@nongnu.org, armbru@redhat.com, alex.williamson@redhat.com, marcel@redhat.com, pbonzini@redhat.com On Mon, Oct 27, 2014 at 07:15:38PM +0200, Marcel Apfelbaum wrote: > On Mon, 2014-10-27 at 11:10 -0600, Eric Blake wrote: > > On 10/27/2014 10:41 AM, Marcel Apfelbaum wrote: > > > Hot-plugging a device that has a romfile (either supplied by user > > > or built-in) using rombar=0 option is an user error, > > > > s/an/a/ (user is pronounced with a leading hard "y" sound rather than a > > soft "u", it may help to remember you can "give a unicorn an umbrella") > Thanks, still hard to get it right, but your tip will surely help :) > > Michael, do you want me to send another version, > or you can change it on the fly? > > Thanks, > Marcel go ahead and repost, easier for me. > > > > > do not allow the device to be hot-plugged. > > > > > > Signed-off-by: Marcel Apfelbaum > > > --- > > > hw/pci/pci.c | 9 +++++++++ > > > 1 file changed, 9 insertions(+) > > > > > > > Reviewed-by: Eric Blake > > > >