From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41852) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xj4mm-0003fk-EI for qemu-devel@nongnu.org; Tue, 28 Oct 2014 07:18:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xj4mg-0003jD-LZ for qemu-devel@nongnu.org; Tue, 28 Oct 2014 07:18:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55179) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xj4mg-0003i4-EF for qemu-devel@nongnu.org; Tue, 28 Oct 2014 07:17:54 -0400 Date: Tue, 28 Oct 2014 11:14:38 +0000 From: Stefan Hajnoczi Message-ID: <20141028111438.GG19211@stefanha-thinkpad.redhat.com> References: <1414256153-10148-1-git-send-email-pl@kamp.de> <1414256153-10148-3-git-send-email-pl@kamp.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Wtrm9ATX0sn6fFKv" Content-Disposition: inline In-Reply-To: <1414256153-10148-3-git-send-email-pl@kamp.de> Subject: Re: [Qemu-devel] [PATCHv3 2/6] block: introduce bdrv_runtime_opts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven Cc: kwolf@redhat.com, famz@redhat.com, benoit@irqsave.net, armbru@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com --Wtrm9ATX0sn6fFKv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Oct 25, 2014 at 06:55:49PM +0200, Peter Lieven wrote: > This patch (orginally by Kevin) adds a bdrv_runtime_opts QemuOptsList. > The list will absorb all options that belong to the BDS (and not the > BlockBackend) and will be parsed and handled in bdrv_open_common. >=20 > Signed-off-by: Kevin Wolf > Signed-off-by: Peter Lieven > Reviewed-by: Max Reitz > --- > block.c | 38 +++++++++++++++++++++++++++++++++----- > 1 file changed, 33 insertions(+), 5 deletions(-) Is this purely because the QemuOptsList API is more convenient than qdict? I don't see a deeper reason why we must use QemuOptsList here. The code is fine, however: Reviewed-by: Stefan Hajnoczi --Wtrm9ATX0sn6fFKv Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUT3qeAAoJEJykq7OBq3PI/qUH/RCCP8DT7hpo5FvgVGdIyseO Y7/b5ZzLsQHQjEO/X7PfOsFamUD+fBXVkYq7o1OPE0HZ3UO4wmLd8z1ZjuoSyda8 MiTtkIXsWdcOcnVr7QjKPIeYPxzzea5LdaJG3LWORc67+LYE0YHbG/UEch6q84TA pBIfJVvcx/r5WOCO7/+JZl0C5ugbc8x6dKcw4W+vJiTLpTyu9n954CgkL2BLRImw JRvhKA+MH9PggLte3qfYS0DeLRE9d80XlB2HOKbWV5xwKcug0i+NNx7pUGC26Q59 MLi4afohoks03291Ko9g24MhXYgv3yz79rTURf8GW5kRyR+ChwcAr86CZSQAPFU= =EuyI -----END PGP SIGNATURE----- --Wtrm9ATX0sn6fFKv--