qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: Peter Lieven <pl@kamp.de>
Cc: kwolf@redhat.com, famz@redhat.com, benoit@irqsave.net,
	armbru@redhat.com, qemu-devel@nongnu.org,
	ronniesahlberg@gmail.com, mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCHv6 0/6] introduce max_transfer_length
Date: Tue, 28 Oct 2014 13:31:29 +0000	[thread overview]
Message-ID: <20141028133129.GA22805@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1414401528-21884-1-git-send-email-pl@kamp.de>

[-- Attachment #1: Type: text/plain, Size: 1887 bytes --]

On Mon, Oct 27, 2014 at 10:18:42AM +0100, Peter Lieven wrote:
> This series adds the basics for introducing a maximum transfer length
> to the block layer. Its main purpose is currently avoiding that
> a multiwrite_merge exceeds the max_xfer_len of an attached iSCSI LUN.
> This is a required bug fix.
> 
> Splitting up requests according to the max_transfer_length will follow
> in a later series.
> 
> v5->v6: - fix parentheses in Patch 1 [Max]
>         - rename helper function in Patch 3 [Max]
>         - cap the limits to highest power of 2 fitting in INT_MAX [Max]
>         - removed full stops in error messages in Patch 6 [Max]
> 
> v4->v5: - Added check for (a != 0 instead of !!a) [Max] and some comments [Eric]
>         - Correctly limited max_transfer_length to INT_MAX in Patch 3 [Max]
>         - Added Patch 5 and Patch 6.
> 
> v3->v4: introduce MIN_NON_ZERO to correctly calculate minimum of 2 limits.
> v2->v3: remove Patch 2 completely [Paolo]
> v1->v2: do not throw errors but generate trace events in Patch 2 [Paolo]
> 
> Peter Lieven (6):
>   util: introduce MIN_NON_ZERO
>   BlockLimits: introduce max_transfer_length
>   block/iscsi: set max_transfer_length
>   block: avoid creating oversized writes in multiwrite_merge
>   block/iscsi: use sector_limits_lun2qemu throughout
>     iscsi_refresh_limits
>   block/iscsi: check for oversized requests
> 
>  block.c                   |    9 +++++++++
>  block/iscsi.c             |   49 ++++++++++++++++++++++++++++++++++-----------
>  include/block/block_int.h |    3 +++
>  include/qemu/osdep.h      |    6 ++++++
>  4 files changed, 55 insertions(+), 12 deletions(-)

Please use "PATCH v6" in the Subject line instead of "PATCHv6".  My
patch scanning tools missed the series.

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan

[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]

      parent reply	other threads:[~2014-10-28 13:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-27  9:18 [Qemu-devel] [PATCHv6 0/6] introduce max_transfer_length Peter Lieven
2014-10-27  9:18 ` [Qemu-devel] [PATCHv6 1/6] util: introduce MIN_NON_ZERO Peter Lieven
2014-10-27  9:18 ` [Qemu-devel] [PATCHv6 2/6] BlockLimits: introduce max_transfer_length Peter Lieven
2014-10-27  9:18 ` [Qemu-devel] [PATCHv6 3/6] block/iscsi: set max_transfer_length Peter Lieven
2014-10-27  9:23   ` Max Reitz
2014-10-27  9:18 ` [Qemu-devel] [PATCHv6 4/6] block: avoid creating oversized writes in multiwrite_merge Peter Lieven
2014-10-27  9:18 ` [Qemu-devel] [PATCHv6 5/6] block/iscsi: use sector_limits_lun2qemu throughout iscsi_refresh_limits Peter Lieven
2014-10-27  9:24   ` Max Reitz
2014-10-27  9:18 ` [Qemu-devel] [PATCHv6 6/6] block/iscsi: check for oversized requests Peter Lieven
2014-10-28 13:31 ` Stefan Hajnoczi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141028133129.GA22805@stefanha-thinkpad.redhat.com \
    --to=stefanha@redhat.com \
    --cc=armbru@redhat.com \
    --cc=benoit@irqsave.net \
    --cc=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=pl@kamp.de \
    --cc=qemu-devel@nongnu.org \
    --cc=ronniesahlberg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).