From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50040) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xj7Br-00009j-Ua for qemu-devel@nongnu.org; Tue, 28 Oct 2014 09:52:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xj7Bm-0006lg-B5 for qemu-devel@nongnu.org; Tue, 28 Oct 2014 09:52:03 -0400 Received: from mail-lb0-x234.google.com ([2a00:1450:4010:c04::234]:50091) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xj7Bm-0006lS-2v for qemu-devel@nongnu.org; Tue, 28 Oct 2014 09:51:58 -0400 Received: by mail-lb0-f180.google.com with SMTP id z12so622881lbi.25 for ; Tue, 28 Oct 2014 06:51:54 -0700 (PDT) Date: Tue, 28 Oct 2014 13:51:51 +0000 From: Stefan Hajnoczi Message-ID: <20141028135151.GC22805@stefanha-thinkpad.redhat.com> References: <1412204151-18117-1-git-send-email-jsnow@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="p2kqVDKq5asng8Dg" Content-Disposition: inline In-Reply-To: <1412204151-18117-1-git-send-email-jsnow@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/6] AHCI Device Fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: kwolf@redhat.com, mst@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, pbonzini@redhat.com --p2kqVDKq5asng8Dg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 01, 2014 at 06:55:45PM -0400, John Snow wrote: > Based off of feedback from the RFC of the same name, > this series batches together a group of fixes that > improve the AHCI device to fix a number of bugs. >=20 > A number of fixes included in the RFC that provide more > radical changes are omitted for now in favor of a smaller, > more easily reviewable set for QEMU 2.2. >=20 > In summary: >=20 > Patch #1 and #6 correct the format of FIS packet responses > that are available to the guest operating system upon interrupt. >=20 > Patch #2 corrects an oversight where we do not inform the > guest how many bytes we've transferred. This is relied upon > for non-NCQ modes and in some early bootup and shutdown code. >=20 > Patch #5 corrects cases with malformed scatter-gather lists that > may cause leaks, or cause QEMU to hang in an allocation loop. >=20 > Patch #4 attempts to continue minimizing the divergence of the > multiple pathways through the AHCI device by re-using existing > callbacks. >=20 > Taken together, these patches should allow non-ncq operation > for Windows hosts, as well as enable hibernation for Windows 7. >=20 > Hibernation for Windows 8 and AHCI remains non-functional. >=20 > John Snow (6): > ahci: Correct PIO/D2H FIS responses > ahci: Update byte count after DMA completion > ide: repair PIO transfers for cases where nsector > 1 > ahci: unify sglist preparation > ide: Correct handling of malformed/short PRDTs > ahci: Fix SDB FIS Construction >=20 > dma-helpers.c | 3 ++ > hw/ide/ahci.c | 113 ++++++++++++++++++++++++++++++++----------------= ------ > hw/ide/ahci.h | 8 ++++ > hw/ide/core.c | 17 ++++++-- > hw/ide/internal.h | 2 + > hw/ide/pci.c | 5 ++- > 6 files changed, 97 insertions(+), 51 deletions(-) Dropped the broken assert that Paolo spotted. Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan --p2kqVDKq5asng8Dg Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUT593AAoJEJykq7OBq3PI7ycH/ApyjaBNmEu80lIv9cdwe91O +HrLx4fo5Cs9YTwnPabf8/4Fcr/d8O823kqoXeiMyx/vF6pvia/JM6/rcDEmDYDD GNaVJoOopGgwPU7+GjQM32PgiKHOPCkCgdm9qR24aAG/Vg2ew4qEcXVCPqoaWuWV 3DOfm7/J/l/tC6bRF+UMgkFslFSuFyLhl+BchirLkzqicjHdaFnJB+DNrxPem62n Abtovp1DiALAo+lPG9Tw9ZAz4biAhG8WiIFWsCRihCsMtnUNzOY5mA+Y+Qfo6KMr iGdOv+D2eE4yH7MI4URcebRZYTdoA6MjQ1F3WEBAA+spbk1oltA6s9wQybDSDXQ= =l3NN -----END PGP SIGNATURE----- --p2kqVDKq5asng8Dg--