From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57317)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1Xj7kc-0002OF-7T
	for qemu-devel@nongnu.org; Tue, 28 Oct 2014 10:28:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1Xj7kW-00020z-2k
	for qemu-devel@nongnu.org; Tue, 28 Oct 2014 10:27:58 -0400
Received: from mx1.redhat.com ([209.132.183.28]:45105)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1Xj7kV-00020v-S3
	for qemu-devel@nongnu.org; Tue, 28 Oct 2014 10:27:52 -0400
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9SERo6w027212
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Tue, 28 Oct 2014 10:27:51 -0400
Date: Tue, 28 Oct 2014 15:27:48 +0100
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20141028142748.GD4828@noname.str.redhat.com>
References: <1414148280-17949-1-git-send-email-mreitz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1414148280-17949-1-git-send-email-mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 0/3] raw-posix: Fix
	raw_co_get_block_status()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Reitz <mreitz@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

Am 24.10.2014 um 12:57 hat Max Reitz geschrieben:
> raw_co_get_block_status() should return 0 and set *pnum to 0 after the
> EOF; currently it does this merely by accident, so implement it
> directly. Also, nb_sectors should be clamped against the image end.
> 
> While doing that, centralize the generation of
> raw_co_get_block_status()'s return value along the way.
> 
> 
> v4:
> - Patch 1: Use DIV_ROUND_UP() for the range until the image end instead
>   of truncating integer division [Eric]
> - Patch 3:
>   - Use qemu-img resize -f raw instrad of truncate [Eric]
>   - Use qemu with HMP qemu-io instead of qemu-io itself; drop the
>     qemu-img test [Eric]

Reviewed-by: Kevin Wolf <kwolf@redhat.com>