From: Stefan Hajnoczi <stefanha@gmail.com>
To: Max Reitz <mreitz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/2] block: JSON filenames and relative backing files
Date: Tue, 28 Oct 2014 16:14:48 +0000 [thread overview]
Message-ID: <20141028161448.GC3969@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1414076175-17034-1-git-send-email-mreitz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1113 bytes --]
On Thu, Oct 23, 2014 at 04:56:13PM +0200, Max Reitz wrote:
> Sometimes, qemu does not have a filename to work with (it then generates
> a JSON filename), so it does not know which directory to use for a
> backing file specified by a relative filename.
>
> In this case, qemu should not somehow try to append the backing file's
> name to the JSON object, but rather just print an error and bail out.
>
>
> Max Reitz (2):
> block: JSON filenames and relative backing files
> iotests: Add test for relative backing file names
>
> block.c | 19 +++++++---
> block/qapi.c | 7 +++-
> include/block/block.h | 2 +-
> tests/qemu-iotests/110 | 87 ++++++++++++++++++++++++++++++++++++++++++++++
> tests/qemu-iotests/110.out | 15 ++++++++
> tests/qemu-iotests/group | 1 +
> 6 files changed, 125 insertions(+), 6 deletions(-)
> create mode 100755 tests/qemu-iotests/110
> create mode 100644 tests/qemu-iotests/110.out
>
> --
> 1.9.3
>
>
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-10-28 16:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 14:56 [Qemu-devel] [PATCH 0/2] block: JSON filenames and relative backing files Max Reitz
2014-10-23 14:56 ` [Qemu-devel] [PATCH 1/2] " Max Reitz
2014-10-23 17:42 ` Eric Blake
2014-10-23 18:00 ` Max Reitz
2014-10-29 15:29 ` Kevin Wolf
2014-10-23 14:56 ` [Qemu-devel] [PATCH 2/2] iotests: Add test for relative backing file names Max Reitz
2014-10-23 17:48 ` Eric Blake
2014-10-23 17:53 ` [Qemu-devel] [PATCH 0/2] block: JSON filenames and relative backing files Eric Blake
2014-10-28 16:14 ` Stefan Hajnoczi [this message]
2014-11-03 11:41 ` Stefan Hajnoczi
2014-11-03 12:00 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141028161448.GC3969@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).