From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55847) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xj9QB-0003BZ-VV for qemu-devel@nongnu.org; Tue, 28 Oct 2014 12:15:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xj9Q5-0008TP-Nd for qemu-devel@nongnu.org; Tue, 28 Oct 2014 12:14:59 -0400 Received: from mail-la0-x230.google.com ([2a00:1450:4010:c03::230]:39435) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xj9Q5-0008T5-Ft for qemu-devel@nongnu.org; Tue, 28 Oct 2014 12:14:53 -0400 Received: by mail-la0-f48.google.com with SMTP id gq15so952930lab.35 for ; Tue, 28 Oct 2014 09:14:52 -0700 (PDT) Date: Tue, 28 Oct 2014 16:14:48 +0000 From: Stefan Hajnoczi Message-ID: <20141028161448.GC3969@stefanha-thinkpad.redhat.com> References: <1414076175-17034-1-git-send-email-mreitz@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="WfZ7S8PLGjBY9Voh" Content-Disposition: inline In-Reply-To: <1414076175-17034-1-git-send-email-mreitz@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/2] block: JSON filenames and relative backing files List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi --WfZ7S8PLGjBY9Voh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 23, 2014 at 04:56:13PM +0200, Max Reitz wrote: > Sometimes, qemu does not have a filename to work with (it then generates > a JSON filename), so it does not know which directory to use for a > backing file specified by a relative filename. >=20 > In this case, qemu should not somehow try to append the backing file's > name to the JSON object, but rather just print an error and bail out. >=20 >=20 > Max Reitz (2): > block: JSON filenames and relative backing files > iotests: Add test for relative backing file names >=20 > block.c | 19 +++++++--- > block/qapi.c | 7 +++- > include/block/block.h | 2 +- > tests/qemu-iotests/110 | 87 ++++++++++++++++++++++++++++++++++++++++= ++++++ > tests/qemu-iotests/110.out | 15 ++++++++ > tests/qemu-iotests/group | 1 + > 6 files changed, 125 insertions(+), 6 deletions(-) > create mode 100755 tests/qemu-iotests/110 > create mode 100644 tests/qemu-iotests/110.out >=20 > --=20 > 1.9.3 >=20 >=20 Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan --WfZ7S8PLGjBY9Voh Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUT8D4AAoJEJykq7OBq3PIvkQH/jLoG0F7hir9bajVBrcaH2Sx iB196v3YCpRrb0Kc7WJhKU3Psv4i5zjXh3yl0k8vdyMXuVcFwIhXBxGFrWBA3T93 0S8uo90D6GteLwGIKEbB5CN/okyIPe2c3LvplKUK5QsvuhOIP90hBfqTgpnsActU qgeGtnWxKEASu73WEmEERDFyd9fQ4ZP82ZsrwuD3wNq52VPKyfHeW+oT4fUQ7meW tNRJOjOOmrtw50vkiCptF8TUDBe/Kfj87Bt4NLHd+ASIS0nO4P/7xX6r/YfB/ufq Ewnj9oQZpq/mFRzAfjSHUl3M7IzIYYAmFO9C5oTtF1HbETadDQ4w4htYZks56oY= =z7sm -----END PGP SIGNATURE----- --WfZ7S8PLGjBY9Voh--