From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33314) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xj9no-0004Zo-9j for qemu-devel@nongnu.org; Tue, 28 Oct 2014 12:39:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xj9ng-0000UQ-Eo for qemu-devel@nongnu.org; Tue, 28 Oct 2014 12:39:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39482) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xj9ng-0000UL-6v for qemu-devel@nongnu.org; Tue, 28 Oct 2014 12:39:16 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9SGdEaP007139 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 28 Oct 2014 12:39:15 -0400 Date: Tue, 28 Oct 2014 17:39:12 +0100 From: Kevin Wolf Message-ID: <20141028163912.GF4828@noname.str.redhat.com> References: <1414404776-4919-1-git-send-email-mreitz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1414404776-4919-1-git-send-email-mreitz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 0/7] block/qcow2: Improve zero cluster expansion List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: qemu-devel@nongnu.org, Stefan Hajnoczi Am 27.10.2014 um 11:12 hat Max Reitz geschrieben: > The main purpose of this series is to add a progress report to > qemu-img amend. This is achieved by adding a callback function to > bdrv_amend_options() - the reasons for this choice are explained in > patch 1. > > While adapting qcow2's expand_zero_clusters_in_l1() accordingly, I > noticed a way to simplify it and get rid of the rather ugly bitmap used > there (patch 6). Had a question on patch 7, but regardless: Reviewed-by: Kevin Wolf